This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Support EIP1193 provider interface #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l provider to Provider
…c method but does not create a new instance since website depends on other properties being available
fabioberger
requested review from
BMillman19,
dekz,
fragosti,
LogvinovLeon and
steveklebanoff
as code owners
fabioberger
changed the title
* development: (37 commits) Factor out redundant source param in parse order functions Fix marquee typo Throw error if cannot find error in table Integrate one-time dump and API for nonfungible.com (#1603) Change optional text props to mandatory in LedgerSignNote Add radar_orders parseRadarOrder test Add parser test for Radar orderbook parsing Moved calculateSlippage from parsers to transformers Show greater than less than when minority has a vote Prettier Recieved -> Received Fix style for address table Hide ledger sign note on error Revert broken formatting Added ledger sign notification Fix bug in ledger address selector where provider does not exist. fix null column constraint issue Add parsing radar order test Rename migration to what it is called on prod and qa Fix type bug around Radar response ...
LogvinovLeon
approved these changes
Feb 20, 2019
packages/assert/src/index.ts
Outdated
| @@ -59,6 +59,7 @@ export const assert = { | |||
| isBoolean(variableName: string, value: boolean): void { | |||
| assert.assert(_.isBoolean(value), assert.typeAssertionMessage(variableName, 'boolean', value)); | |||
| }, | |||
| // DEPRECATED: Please use providerUtils.standardizeOrThrow() instead | |||
There was a problem hiding this comment.
This comment will live here forever and no one will ever see it. Can we use logUtils.warn instead?
packages/assert/test/assert_test.ts
Outdated
| @@ -154,18 +154,6 @@ describe('Assertions', () => { | |||
| invalidInputs.forEach(input => expect(assert.isBoolean.bind(assert, variableName, input)).to.throw()); | |||
| }); | |||
| }); | |||
| describe('#isWeb3Provider', () => { | |||
There was a problem hiding this comment.
Let's live it here before we remove the code.
* development: Add constraint name to down phase as well Give the constraint an explicit name of token_orderbook_snapshots_pkey Remove comments Fix inconsistently named constraint
dekz
suggested changes
Feb 21, 2019
…stallation and the latest version has a bug
… by external devs
* development: Demonstrate calling contracts with tuple arrays (#1615) removed default meta tags in public/index.html fixed linting issue updated documentTitle component added metadata for pages (incomplete) fixed title comment-out removed react-document-title in favor of using react-helmet for consistency and bug fix
dekz
approved these changes
Feb 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for EIP 1193 & [email protected] providers and transforms supplied providers into a consistent internal provider interface.
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.