Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Decode NULL as False in Abi Encoder #1582

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Decode NULL as False in Abi Encoder #1582

merged 2 commits into from
Feb 5, 2019

Conversation

hysz
Copy link
Contributor

@hysz hysz commented Feb 4, 2019 •
edited
Loading

Description

There are some cases where the client returns 0x instead of 0x0....

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@hysz hysz changed the title Added SignatureValidator test case when hash is not preSigned [WIP] Added SignatureValidator test case when hash is not preSigned Feb 4, 2019
@hysz hysz force-pushed the fix/utils/abiDecodeNullAsFalse branch from a149c0c to a030a49 Compare February 4, 2019 19:25
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.166% when pulling a030a49 on fix/utils/abiDecodeNullAsFalse into 74293d5 on development.

@coveralls
Copy link

coveralls commented Feb 4, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 85.166% when pulling a3198b7 on fix/utils/abiDecodeNullAsFalse into 74293d5 on development.

@hysz hysz force-pushed the fix/utils/abiDecodeNullAsFalse branch from a030a49 to 785f979 Compare February 5, 2019 00:27
@hysz hysz force-pushed the fix/utils/abiDecodeNullAsFalse branch from 785f979 to 1e1cf07 Compare February 5, 2019 00:31
@hysz hysz force-pushed the fix/utils/abiDecodeNullAsFalse branch from 1e1cf07 to db900d1 Compare February 5, 2019 00:32
@hysz hysz changed the title [WIP] Added SignatureValidator test case when hash is not preSigned Decode NULL as False in Abi Encoder Feb 5, 2019
@hysz hysz requested a review from fabioberger February 5, 2019 00:34
@fabioberger fabioberger merged commit b2f3505 into development Feb 5, 2019
@fabioberger fabioberger deleted the fix/utils/abiDecodeNullAsFalse branch February 5, 2019 10:32
This was referenced Oct 9, 2021
Open
Open
Open
This was referenced Feb 4, 2022
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabioberger fabioberger fabioberger approved these changes

Assignees
No one assigned
Labels
contracts @0x/utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hysz @coveralls @fabioberger