Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Sol tracing fixes #1535

Merged
merged 17 commits into from
Jan 22, 2019
Merged

Sol tracing fixes #1535

merged 17 commits into from
Jan 22, 2019

Conversation

LogvinovLeon
Copy link
Contributor

@LogvinovLeon LogvinovLeon commented Jan 22, 2019 •
edited by fabioberger
Loading

Description

  • Fix a bug when some parts of the profiling report were missing because of the coverage ignore lines /* solcov ignore next */
  • SolCompilerArtifactAdapter now uses SolResolver under the hood which allows to resolve NPM dependencies properly. Before it was just throwing.
  • Cache the utils.getContractDataIfExists leading to faster execution
  • SolCompilerArtifactAdapter now doesn't return the ContractData for interfaces
  • Print reasonable error message on bytecode collision

Testing instructions

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@coveralls
Copy link

coveralls commented Jan 22, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 85.212% when pulling 8ce8850 on feature/sol-tracing-monorepo-fixes into 8d367a0 on development.

fabioberger
fabioberger approved these changes Jan 22, 2019
View reviewed changes
contracts/utils/CHANGELOG.json Outdated Show resolved Hide resolved
packages/sol-profiler/CHANGELOG.json Outdated Show resolved Hide resolved
packages/sol-tracing-utils/CHANGELOG.json Outdated Show resolved Hide resolved
packages/sol-tracing-utils/CHANGELOG.json Outdated Show resolved Hide resolved
packages/sol-tracing-utils/CHANGELOG.json Outdated Show resolved Hide resolved
packages/sol-tracing-utils/CHANGELOG.json Outdated Show resolved Hide resolved
packages/sol-tracing-utils/src/artifact_adapters/sol_compiler_artifact_adapter.ts Outdated Show resolved Hide resolved
packages/sol-tracing-utils/src/collect_coverage_entries.ts Outdated Show resolved Hide resolved
fabioberger and others added 10 commits January 22, 2019 13:29
@fabioberger @LogvinovLeon
Update contracts/utils/CHANGELOG.json
4a6bdfa 
Co-Authored-By: LogvinovLeon <[email protected]>
@fabioberger @LogvinovLeon
Update packages/sol-profiler/CHANGELOG.json
d8890a0 
Co-Authored-By: LogvinovLeon <[email protected]>
@fabioberger @LogvinovLeon
Update packages/sol-tracing-utils/src/collect_coverage_entries.ts
19f9297 
Co-Authored-By: LogvinovLeon <[email protected]>
@fabioberger @LogvinovLeon
Update packages/sol-tracing-utils/CHANGELOG.json
3297b5e 
Co-Authored-By: LogvinovLeon <[email protected]>
@fabioberger @LogvinovLeon
Update packages/sol-tracing-utils/CHANGELOG.json
c3ecbd3 
Co-Authored-By: LogvinovLeon <[email protected]>
@fabioberger @LogvinovLeon
Update packages/sol-tracing-utils/CHANGELOG.json
aedd650 
Co-Authored-By: LogvinovLeon <[email protected]>
@fabioberger @LogvinovLeon
Update packages/sol-tracing-utils/CHANGELOG.json
148f12a 
Co-Authored-By: LogvinovLeon <[email protected]>
@LogvinovLeon
Fix a typo
7c47c52
@LogvinovLeon
Refactor out isInterfaceContract
3e910c0
@LogvinovLeon
Change strings to numbers in CHANGELOGs
8ce8850
@LogvinovLeon LogvinovLeon merged commit cc48433 into development Jan 22, 2019
@LogvinovLeon LogvinovLeon deleted the feature/sol-tracing-monorepo-fixes branch January 22, 2019 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabioberger fabioberger fabioberger approved these changes

Assignees
No one assigned
Labels
contracts @0x/sol-coverage @0x/sol-profiler @0x/sol-tracing-utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LogvinovLeon @coveralls @fabioberger