Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Fix expectedAmountAvailableToFill test #1511

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Fix expectedAmountAvailableToFill test #1511

merged 2 commits into from
Jan 15, 2019

Conversation

steveklebanoff
Copy link
Contributor

Description

With c8c8219 I made amountAvailableToFill required, but there was a test that still relied on the optional amountAvailableToFill behavior

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@coveralls
Copy link

coveralls commented Jan 11, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 85.324% when pulling 7a2b312 on fix/asset-buyer/zero-amount-available-test into f570f80 on development.

@LogvinovLeon LogvinovLeon changed the title [asset-buyer] Fix expectedAmountAvailableToFill test Fix expectedAmountAvailableToFill test Jan 15, 2019
@steveklebanoff steveklebanoff merged commit 39816be into development Jan 15, 2019
@snyk-bot snyk-bot mentioned this pull request Jan 13, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 10, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fragosti fragosti fragosti approved these changes

@BMillman19 BMillman19 Awaiting requested review from BMillman19

Assignees
No one assigned
Labels
@0x/asset-buyer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steveklebanoff @coveralls @fragosti