Sol tracing fixes #1498

recmo · 2019-01-09T18:58:34Z

Description

This PR fixes some of the issues in trace-based tools that we've discovered.

We now use custom JS tracer on nodes that support it (Geth only)
Before we assumed that source file ids are in order. That's not true and led to incorrect source map parsing. We now fixed that, but it required us to change the format of the ContractData and it's used by custom artifact adapters, so that's a breaking change.
Added support for assembly

Testing instructions

Types of changes

Bug fix (non-breaking change which fixes an issue)

Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Prefix PR title with [WIP] if necessary.
Add tests to cover changes as needed.
Update documentation as needed.
Add new entries to the relevant CHANGELOG.jsons.

coveralls · 2019-01-11T10:44:15Z

Coverage decreased (-0.06%) to 85.389% when pulling a662901 on fix/sol-cov into 797d7c7 on development.

…ata from an array to a mapping

packages/sol-tracing-utils/CHANGELOG.json

packages/sol-tracing-utils/src/artifact_adapters/sol_compiler_artifact_adapter.ts

packages/sol-tracing-utils/src/source_maps.ts

packages/sol-tracing-utils/src/trace_collection_subprovider.ts

packages/sol-tracing-utils/src/trace_info_subprovider.ts

Co-Authored-By: LogvinovLeon <[email protected]>

recmo · 2019-01-15T03:38:15Z

packages/sol-tracing-utils/src/trace_collection_subprovider.ts

+        }
+    }
+    return wrappedAsync;
+}


This hack is going in? I was hoping we would come up with something better :)

You're absolutely right. I've figured out how to fix it.

Oops, I was wrong and I from the past was right. Not about the fact that we shouldn't handle this but about the fact that there is no elegant way to do so.

This reverts commit 7ea274b.

packages/sol-tracing-utils/src/trace_collection_subprovider.ts

Co-Authored-By: LogvinovLeon <[email protected]>

recmo requested a review from LogvinovLeon January 9, 2019 18:58

recmo requested a review from albrow as a code owner January 9, 2019 18:58

probot-autolabeler bot added @0x/ethereum-types @0x/sol-cov labels Jan 9, 2019

LogvinovLeon self-assigned this Jan 10, 2019

fabioberger and others added 7 commits January 11, 2019 11:26

Re-add changelog for 0x.js

4dbd3ea

Add tracer params type

27c4d25

Fix typo

4d03c30

Throw error when source location is missing

296b3d6

Capture errors in next callbacks

7af0818

Use tracer for debug traces

e1b99b5

Generate blocks at interval for truffle

d9ac5b6

LogvinovLeon force-pushed the fix/sol-cov branch from ec7a4d3 to d9ac5b6 Compare January 11, 2019 10:26

probot-autolabeler bot added 0x.js contracts labels Jan 11, 2019

LogvinovLeon added 2 commits January 11, 2019 11:28

Remove generated artifacts

0b38513

Remove generated wrappers

66add14

probot-autolabeler bot added @0x/sol-coverage @0x/sol-tracing-utils labels Jan 11, 2019

Revert CHANGELOG changes

bb99245

LogvinovLeon added 4 commits January 14, 2019 11:39

Use a custom JS tracer

ab5cd8f

Add assembly statements to AST Visitor

2345a3b

Add utils.isRangeEqual to sol-profiler

8b62783

Fix the bug with incorrect source maps parsing by changing contract d…

2581bc9

…ata from an array to a mapping

probot-autolabeler bot added the @0x/sol-trace label Jan 14, 2019

LogvinovLeon added 2 commits January 14, 2019 12:16

Fix linter

2b8f0d8

Merge development

bf183af

LogvinovLeon changed the title ~~[WIP] Fix/sol cov~~ Sol tracing fixes Jan 14, 2019

Add CHANGELOG entries

bd71f4a

LogvinovLeon added 2 commits January 14, 2019 12:53

Use custom JS tracer only if the node is geth

092a851

Apply prettier

4b9648c

fabioberger suggested changes Jan 14, 2019

View reviewed changes

fabioberger and others added 10 commits January 14, 2019 13:50

Update packages/sol-tracing-utils/CHANGELOG.json

45d70dd

Co-Authored-By: LogvinovLeon <[email protected]>

Update packages/sol-tracing-utils/CHANGELOG.json

b41bcd8

Co-Authored-By: LogvinovLeon <[email protected]>

Update packages/sol-tracing-utils/src/source_maps.ts

1c279f9

Co-Authored-By: LogvinovLeon <[email protected]>

Update packages/sol-tracing-utils/src/trace_collection_subprovider.ts

ed3b89f

Co-Authored-By: LogvinovLeon <[email protected]>

Update packages/sol-tracing-utils/src/trace_info_subprovider.ts

caba2fa

Co-Authored-By: LogvinovLeon <[email protected]>

Update packages/sol-tracing-utils/CHANGELOG.json

e14f164

Co-Authored-By: LogvinovLeon <[email protected]>

Update packages/sol-tracing-utils/src/source_maps.ts

1f7179b

Co-Authored-By: LogvinovLeon <[email protected]>

Add a link to tracing examples

02543fd

Add SourceCodes and Sources types

4689309

Rename mappins to have a direct naming scheme instead of a reverse one

83b46cb

LogvinovLeon force-pushed the fix/sol-cov branch from d24c2a3 to 83b46cb Compare January 14, 2019 13:52

recmo commented Jan 15, 2019

View reviewed changes

Export Sources and SourceCodes out of tracing utils

a8e32d8

LogvinovLeon force-pushed the fix/sol-cov branch from a662901 to a8e32d8 Compare January 15, 2019 10:34

probot-autolabeler bot added the @0x/sol-profiler label Jan 15, 2019

LogvinovLeon added 5 commits January 15, 2019 11:48

Refactor logAsyncErrors to follow our conventions

d9675ad

Remove logAsyncErrors hack

7ea274b

Revert "Remove logAsyncErrors hack"

c2ec417

This reverts commit 7ea274b.

Remove unused tslint disable

75a4bbc

Make mapping namings direct

63a6354

LogvinovLeon force-pushed the fix/sol-cov branch from e6c1e5f to 63a6354 Compare January 15, 2019 12:37

fabioberger approved these changes Jan 15, 2019

View reviewed changes

packages/sol-tracing-utils/src/trace_collection_subprovider.ts Outdated Show resolved Hide resolved

Update packages/sol-tracing-utils/src/trace_collection_subprovider.ts

64d99dc

Co-Authored-By: LogvinovLeon <[email protected]>

LogvinovLeon merged commit 1808458 into development Jan 15, 2019

LogvinovLeon deleted the fix/sol-cov branch January 15, 2019 13:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sol tracing fixes #1498

Sol tracing fixes #1498

recmo commented Jan 9, 2019 •

edited by LogvinovLeon

Loading

coveralls commented Jan 11, 2019 •

edited

Loading

recmo Jan 15, 2019

LogvinovLeon Jan 15, 2019

LogvinovLeon Jan 15, 2019

Sol tracing fixes #1498

Sol tracing fixes #1498

Conversation

recmo commented Jan 9, 2019 • edited by LogvinovLeon Loading

Description

Testing instructions

Types of changes

Checklist:

coveralls commented Jan 11, 2019 • edited Loading

recmo Jan 15, 2019

Choose a reason for hiding this comment

LogvinovLeon Jan 15, 2019

Choose a reason for hiding this comment

LogvinovLeon Jan 15, 2019

Choose a reason for hiding this comment

recmo commented Jan 9, 2019 •

edited by LogvinovLeon

Loading

coveralls commented Jan 11, 2019 •

edited

Loading