This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Refactor out sol-cov, sol-profiler and sol-trace into their separate packages #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogvinovLeon
changed the title
LogvinovLeon
force-pushed
the
feature/sol-cov-sol-profiler-sol-trace-divorce
branch
from
e983cdd to
1c783d2
Compare
LogvinovLeon
requested review from
BMillman19,
fabioberger,
fragosti and
steveklebanoff
as code owners
LogvinovLeon
changed the title
LogvinovLeon
force-pushed
the
feature/sol-cov-sol-profiler-sol-trace-divorce
branch
3 times, most recently
from
dfa12a0 to
05916aa
Compare
LogvinovLeon
force-pushed
the
feature/sol-cov-sol-profiler-sol-trace-divorce
branch
from
e3e41e7 to
2c974b5
Compare
LogvinovLeon
force-pushed
the
feature/sol-cov-sol-profiler-sol-trace-divorce
branch
from
528e67e to
0324824
Compare
fabioberger
suggested changes
Jan 9, 2019
package.json
Outdated
| @@ -62,6 +62,9 @@ | |||
| "repoBranchBase": "development" | |||
| } | |||
| }, | |||
| "resolutions": { | |||
| "graceful-fs": "4.1.15" | |||
There was a problem hiding this comment.
I ran into that issue on my machine gulpjs/gulp#2246
| @@ -6,6 +6,11 @@ import * as _ from 'lodash'; | |||
| import { EvmCallStack } from './types'; | |||
| import { utils } from './utils'; | |||
|
|
|||
| /** | |||
| * Converts linear trace to a call stack by following calls and returns | |||
| * @param structLogs Linear trace | |||
There was a problem hiding this comment.
Suggested change
| * @param structLogs Linear trace | |
| * @param structLogs Linear trace |
There was a problem hiding this comment.
You've made no changes to the code
| @@ -1,17 +1,17 @@ | |||
| Sol-cov uses transaction traces in order to figure out which lines of Solidity source code have been covered by your tests. In order for it to gather these traces, you must add the `CoverageSubprovider` to the [ProviderEngine](https://github.com/MetaMask/provider-engine) instance you use when running your Solidity tests. If you're unfamiliar with ProviderEngine, please read the [Web3 Provider explained](https://0x.org/wiki#Web3-Provider-Explained) wiki article. | |||
There was a problem hiding this comment.
Rename dir from sol_cov to sol_coverage
There was a problem hiding this comment.
This file was removed. The new directory has the correct name.
Before we've had two. v1 and v2. Git decided (correctly) that v2 was moved and renamed and v1 just removed.
Co-Authored-By: LogvinovLeon <[email protected]>
Co-Authored-By: LogvinovLeon <[email protected]>
Co-Authored-By: LogvinovLeon <[email protected]>
Co-Authored-By: LogvinovLeon <[email protected]>
Co-Authored-By: LogvinovLeon <[email protected]>
Co-Authored-By: LogvinovLeon <[email protected]>
Co-Authored-By: LogvinovLeon <[email protected]>
LogvinovLeon
force-pushed
the
feature/sol-cov-sol-profiler-sol-trace-divorce
branch
from
2fbc17b to
1bdffbf
Compare
LogvinovLeon
force-pushed
the
feature/sol-cov-sol-profiler-sol-trace-divorce
branch
from
1bdffbf to
cee2954
Compare
fabioberger
approved these changes
Jan 10, 2019
LogvinovLeon
deleted the
feature/sol-cov-sol-profiler-sol-trace-divorce
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before that PR there was a
@0x/sol-covpackage with sol-trace and sol-profiler living as dirty hacks inside. From now on there are 4 packages:@0x/sol-coverage@0x/sol-trace@0x/sol-profiler@0x/sol-trace-based-tools-common(Maybe a better name)All the old CHANGELOG entries live in the common. The new changelogs reference it.
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.