Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

[web3-wrapper] Only unmarshall receipt if blockNumber present #1308

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

dekz
Copy link
Member

@dekz dekz commented Nov 23, 2018

#1307

Description

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Prefix PR title with bracketed package name(s) corresponding to the changed package(s). For example: [sol-cov] Fixed bug.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@coveralls
Copy link

coveralls commented Nov 23, 2018

Coverage Status

Coverage increased (+0.009%) to 85.285% when pulling 03b3b80 on bug/web3-wrapper/unmarshall-parity-receipt into a5359df on development.

openethereum/parity-ethereum#1180
Parity can return a pending transaction receipt with a number of null values
@dekz dekz force-pushed the bug/web3-wrapper/unmarshall-parity-receipt branch from 49feb14 to 03b3b80 Compare November 23, 2018 04:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants