Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

[monorepo-scripts] Format changelog dates as UTC timezone +0:00 #1143

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

dekz
Copy link
Member

@dekz dekz commented Oct 17, 2018

Description

Down under is in the future and causes many conflicts when formatting the timestamp in the local context. All previous releases jumped a day ahead. By setting this to UTC we will have consistent formatted dates in the changelogs no matter where one publishes from.

npm-cli-login fails on node 10 as a deprecation in node 9 has finished. This package appears to be unmaintained so we now have a fork with a fix

Before:

-## v1.0.8 - _October 4, 2018_
+## v2.0.0 - _October 17, 2018_
+
+    * Add support for `eth_signTypedData`. (#1102)
+    * Added `MetamaskSubprovider` to handle inconsistencies in Metamask's signing JSON RPC endp
+    * Removed `SignerType` (including `SignerType.Metamask`). Please use the `MetamaskSubprovid
+    * Updated to use new modularized artifacts and the latest version of @0xproject/contract-wr
+    * Make web3-provider-engine types a 'dependency' so it's available to users of the library
+
+## v1.0.8 - _October 5, 2018_

     * Dependencies updated

-## v1.0.7 - _September 28, 2018_
+## v1.0.7 - _September 29, 2018_

     * Dependencies updated

-## v1.0.6 - _September 25, 2018_
+## v1.0.6 - _September 26, 2018_

After:

+## v2.0.0 - _October 17, 2018_
+
+    * Add support for `eth_signTypedData`. (#1102)
+    * Added `MetamaskSubprovider` to handle inconsistencies in Metamask's signing JSON RPC endp
+    * Removed `SignerType` (including `SignerType.Metamask`). Please use the `MetamaskSubprovid

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Prefix PR title with bracketed package name(s) corresponding to the changed package(s). For example: [sol-cov] Fixed bug.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@dekz dekz requested review from albrow and fabioberger October 17, 2018 03:18
@dekz dekz force-pushed the fix/monorepo-scripts/changelog-utc branch 2 times, most recently from f3d9845 to 9e360d0 Compare October 17, 2018 03:24
Down under is in the future and causes many conflicts when formatting the timestamp in the local context. All previous releases jumped a day ahead. By setting this to UTC we will have consistent formatted dates in the changelogs no matter where one publishes from.

npm-cli-login fails on node 10 as a deprecation in node 9 has finished. This package appears to be unmaintained so we now have a fork with a fix
@dekz dekz force-pushed the fix/monorepo-scripts/changelog-utc branch from 9e360d0 to 0013baf Compare October 17, 2018 03:25
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.679% when pulling 0013baf on fix/monorepo-scripts/changelog-utc into 336e456 on development.

@dekz dekz merged commit 78e6063 into development Oct 17, 2018
@dekz dekz deleted the fix/monorepo-scripts/changelog-utc branch October 17, 2018 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants