This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
[asset-buyer][monorepo-scripts][website] Add asset-buyer documentation #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BMillman19
force-pushed
the
feature/website/asset-buyer-docs
branch
from
f562dfa to
aa1085c
Compare
fragosti
reviewed
Oct 16, 2018
| A [BuyQuote](#types-BuyQuote) object contains enough information to display buy information to an end user | ||
|
|
||
| ```typescript | ||
| const erc20TokenAddress = '0x5fa3c....'; |
There was a problem hiding this comment.
why not the entire address? The rest of the code looks like it works.
| Pass the [BuyQuote](#types-BuyQuote) object from above back to the assetBuyer in order to initiate the buy transaction | ||
|
|
||
| ```typescript | ||
| const txHash = await assetBuyer.executeBuyQuoteAsync(buyQuote); // the hash of the transaction submitted to the Ethereum network |
There was a problem hiding this comment.
I still think it would be nice to have a executeBuyQuoteAsyncAndWaitForTransactionMined or something.
fragosti
approved these changes
Oct 16, 2018
There was a problem hiding this comment.
Anyway looks good to me. Maybe @fabioberger has some comments.
* development: (31 commits) Update CODEOWNERS Update CODEOWNERS Update CODEOWNERS Add leo to CODEOWNERS on some packages fix(monorepo-scripts): Format date as UTC not local time. Bump max bundle size for instant fix: dont use enum string as type as typedoc gets confused feat: export AssetData from order-utils feat: export AssetData from utils chore: temporarily increase the bundle size for instant Remove order-utils from dependencies Run tests on circle CI Add tests for format and use toFixed instead of round for usd Remove expiry buffer seconds option from AssetBuyer init Add ts-optchain and use it instead of lodash get Hide USD price when ETH-USD price is not available Rename OrderDetailsRow to EthAmountRow fix: add Steve's github account to about page, and capitalize AppFolio correctly Put boundNoop in a util file Add tnxHash to buy button callbacks ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for
@0xproject/asset-buyerto the website.Testing instructions
http://staging-0xproject.s3-website-us-east-1.amazonaws.com/docs/asset-buyer
Types of changes
Checklist:
[WIP]if necessary.[sol-cov] Fixed bug.