-
Notifications
You must be signed in to change notification settings - Fork 465
[order-watcher] Public function getStats #1118
Conversation
Thanks a lot for this @amaurer! Do you think there might be additional stats we'd want to track in the future? Trying to decide if we want to make this a more generic |
That makes sense so that, it is expandable and won't break interfaces in consuming applications. Changed to getStats which returns a Stats object with orderCount as a property. @fabioberger |
Thanks for changing that @amaurer! Looks good, just minor fixes then we can merge and publish. |
Also, could you run |
@amaurer thanks for addressing my comments. Can you also export Once this is done and the conflicts are resolved, I'll approve & merge. |
Description
Added public function to get order watcher counts so I can effectively scale order watcher instances based on watch loads.
Testing instructions
Function added to test suite, no real changes as it reads in internal property that is assumed properly maintained.
Types of changes
Added function for getWatchCounts in order watcher and one test.
Checklist:
[WIP]
if necessary.[sol-cov] Fixed bug
.