This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
[asset-buyer] Fix order expiration calc bug and expose gas options to executeBuyQuote #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fragosti
changed the title
fabioberger
reviewed
Oct 9, 2018
| @@ -8,7 +8,7 @@ const MAINNET_NETWORK_ID = 1; | |||
| const DEFAULT_ASSET_BUYER_OPTS: AssetBuyerOpts = { | |||
| networkId: MAINNET_NETWORK_ID, | |||
| orderRefreshIntervalMs: 10000, // 10 seconds | |||
| expiryBufferSeconds: 15, | |||
| expiryBufferSeconds: 300, | |||
There was a problem hiding this comment.
How was this number chosen? Can you leave a comment?
* development: Define bundlewatch.ci.repoBranchBase Stop accesing ethers private methods Fix merge conflicts Fix ethers build issue Upgrade ethers.js version Fix branch name Add max sizes Use bundlewatch instead of bundlesize Move Metamask Error to OrderErrors Update the exported types for the packages which touch RPC providers Throw and handle errors from Providers. Clarifies use of schemas outside of Javascript/TypeScript. Detect MM on signature validation failure. Return SignedOrder from signing utils. Update 0x.js Changelog Add eth_signTypedData support to our wallet subproviders Move SignTypedData to utils package Introduce Metamask Subprovider. Expose eth_signTypedData functionality for order signing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some small tweaks that came out of playing with asset-buyer.
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.[sol-cov] Fixed bug.