Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Add transactionHash to OrderState and emit it from OrderWatcher #1087

Merged
merged 2 commits into from
Sep 25, 2018
Merged

Add transactionHash to OrderState and emit it from OrderWatcher #1087

merged 2 commits into from
Sep 25, 2018

Conversation

fabioberger
Copy link
Contributor

Description

Addresses: #1017

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Prefix PR title with bracketed package name(s) corresponding to the changed package(s). For example: [sol-cov] Fixed bug.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 85.005% when pulling 9eecf36 on addTxHashToOrderState into 7570f3d on development.

@fabioberger fabioberger merged commit b73df28 into development Sep 25, 2018
@fabioberger fabioberger deleted the addTxHashToOrderState branch September 25, 2018 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LogvinovLeon LogvinovLeon LogvinovLeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabioberger @coveralls @LogvinovLeon