This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Fix block fetch error if block not found #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogvinovLeon
approved these changes
Sep 24, 2018
packages/web3-wrapper/CHANGELOG.json
Outdated
| "changes": [ | ||
| { | ||
| "note": | ||
| "Rename `getBlockAsync` to `getBlockIfExistsAsync` and rather then throw if the requested block wasn't found, return undefined." |
| @@ -329,23 +329,28 @@ export class Web3Wrapper { | |||
| /** | |||
| * Fetch a specific Ethereum block without transaction data | |||
| * @param blockParam The block you wish to fetch (blockHash, blockNumber or blockLiteral) | |||
| * @returns The requested block without transaction data | |||
| * @returns The requested block without transaction data, or undefined if block was not found | |||
There was a problem hiding this comment.
Can we add a comment why the block could be not found?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
web3Wrapper.getBlockAsyncthrows:If the request for a particular block fails. A block request could fail if a node isn't fully synced, or if it's become uncle'd, among other reasons. The Ethereum JSON RPC spec specified returning
nullfor requests where the block cannot be found.This PR therefore renames
getBlockAsynctogetBlockIfExistsAsyncand returnsundefined(in-line with our codebase conventions) if the block was not found.Testing instructions
Types of changes
Checklist:
[WIP]if necessary.[sol-cov] Fixed bug.