This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Fix dropped events issue in Order-watcher and Contract-wrappers subscriptions #1080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to the acceptance and implementation of EIP234 by Geth and Parity, it was not possible to fetch blocks by
blockHash
. This lead to the incorrect logs being returned for blocks that got uncled during a block-reorg. What made matters worse is that instead of throwing an error for ablockNumber
the node didn't know about, it would return an empty set of logs, making a block without logs indistinguishable from an unknown block.This PR updates our code to fix this issue, which should make our event watching much more robust.
Testing instructions
Types of changes
Checklist:
[WIP]
if necessary.[sol-cov] Fixed bug
.