Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

[typescript-typings] Remove types that were moved to DefinitelyTyped #1052

Merged
merged 11 commits into from
Sep 4, 2018
Merged

[typescript-typings] Remove types that were moved to DefinitelyTyped #1052

merged 11 commits into from
Sep 4, 2018

Conversation

LogvinovLeon
Copy link
Contributor

@LogvinovLeon LogvinovLeon commented Sep 4, 2018 •
edited
Loading

Description

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Prefix PR title with bracketed package name(s) corresponding to the changed package(s). For example: [sol-cov] Fixed bug.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@LogvinovLeon LogvinovLeon changed the title Remove types that were moved to DefinitelyTyped [typescript-typings] Remove types that were moved to DefinitelyTyped Sep 4, 2018
@coveralls
Copy link

coveralls commented Sep 4, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 85.709% when pulling 40e0c82 on feature/remove-types into 78d4fc5 on development.

fabioberger
fabioberger reviewed Sep 4, 2018
View reviewed changes
packages/subproviders/package.json Outdated
"@types/lodash": "4.14.104",
"@types/mocha": "^2.2.42",
"@types/node": "^8.0.53",
"@types/sinon": "^2.2.2",
"@types/ganache-core": "^2.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this needs to be a dependency since we expose some of it's types in the public interface.

packages/subproviders/package.json Outdated
@@ -52,13 +52,16 @@
"devDependencies": {
"@0xproject/tslint-config": "^1.0.6",
"@types/bip39": "^2.4.0",
"@types/eth-lightwallet": "^3.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as below.

@LogvinovLeon LogvinovLeon merged commit a52714b into development Sep 4, 2018
@LogvinovLeon LogvinovLeon deleted the feature/remove-types branch September 4, 2018 16:00
This was referenced May 13, 2022
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request May 13, 2022
Closed
This was referenced May 14, 2022
Closed
Closed
Closed
Closed
Closed
Closed
@adamlaska adamlaska mentioned this pull request May 14, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabioberger fabioberger fabioberger approved these changes

@BMillman19 BMillman19 Awaiting requested review from BMillman19

@fragosti fragosti Awaiting requested review from fragosti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LogvinovLeon @coveralls @fabioberger