Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

[asset-buyer] Create new AssetBuyer class #1037

Merged
merged 43 commits into from
Sep 24, 2018
Merged

[asset-buyer] Create new AssetBuyer class #1037

Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
8687b95
Add getForwarderHelperForMakerAssetDataAsync method to forwarderHelpe…
BMillman19 Aug 24, 2018
8d61327
Remove taker address as param and filter out non-open orders
BMillman19 Sep 13, 2018
c0a14a4
Catch standard relayer api errors
BMillman19 Sep 13, 2018
90674d9
Various clean up
BMillman19 Sep 14, 2018
91702bb
Move packages/forwarder-helper into packages/asset-buyer
BMillman19 Sep 14, 2018
8da7d39
Update readme, changelog, and package.json with rename
BMillman19 Sep 14, 2018
7b46cef
Create initial AssetBuyer class
BMillman19 Sep 14, 2018
f1a22e9
Flesh out the AssetBuyer class
BMillman19 Sep 15, 2018
190bf25
Implement StandardRelayerAPIOrderFetcher
BMillman19 Sep 15, 2018
4e59be9
Implement ProvidedOrderFetcher
BMillman19 Sep 15, 2018
dfe58e4
Delete old test
BMillman19 Sep 15, 2018
c692115
Fix lint errors
BMillman19 Sep 15, 2018
d57619b
Export the order fetchers
BMillman19 Sep 15, 2018
af40989
Add factory method on AssetBuyer for provided orders
BMillman19 Sep 15, 2018
9ec2b5a
Add factory method on AssetBuyer for specific token address
BMillman19 Sep 15, 2018
a22d2dc
Add factory method for specific assetData to buy and add comments
BMillman19 Sep 15, 2018
f5dbf21
Merge branch 'development' of https://github.com/0xProject/0x-monorep…
fragosti Sep 18, 2018
65f709d
Move all constants to own file
fragosti Sep 18, 2018
38afd10
Fix order expired bug
fragosti Sep 18, 2018
b947609
Restrict orders field of AssetBuyerOrdersAndFillableAmounts to Signed…
fragosti Sep 18, 2018
0003666
make the slippage percentage customizable by integrator
fragosti Sep 18, 2018
fd4b4f8
Make ForwaderWrapper take in a number for feePercentage instead of Bi…
fragosti Sep 18, 2018
93f7e33
Add isValidPercentage assert
fragosti Sep 18, 2018
60e2dfd
Calculate min and max rates in buy quote
fragosti Sep 19, 2018
14345ab
Rename forceOrderRefresh to shouldForceOrderRefresh
fragosti Sep 19, 2018
a03b1d4
Move ObjectMap to shared types
fragosti Sep 19, 2018
a44f77a
Implement StandardRelayerAPIAssetBuyerManager
fragosti Sep 19, 2018
3238925
Add better description to README
fragosti Sep 20, 2018
d23487b
Update descriptions for methods on AssetBuyer
fragosti Sep 20, 2018
03e18ff
Rename OrderFetcher to OrderProvider and other small improvements
fragosti Sep 20, 2018
35c324f
Add utility to get assetDatas
fragosti Sep 20, 2018
fcca63a
Move some logic to order utils
fragosti Sep 20, 2018
97150cf
Add labels to TODOs
fragosti Sep 21, 2018
8dea48e
Renamed orderFetcherResponseProcessor to orderProviderResponseProcessoer
fragosti Sep 21, 2018
c64dcec
More renaming
fragosti Sep 21, 2018
c48cf3a
Make asset buyer map private
fragosti Sep 21, 2018
1bfaefb
Add order provider response validation
fragosti Sep 21, 2018
5e84e96
Small typos
fragosti Sep 21, 2018
7a53766
Merge branch 'development' of https://github.com/0xProject/0x-monorep…
fragosti Sep 21, 2018
e4b664b
Add expiry buffer
fragosti Sep 24, 2018
7a43e19
Improve README
fragosti Sep 24, 2018
f49b231
Merge branch 'development' of https://github.com/0xProject/0x-monorep…
fragosti Sep 24, 2018
d8d1c98
Upgrade all deps
fragosti Sep 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 packages/forwarder-helper/.npmignore → packages/asset-buyer/.npmignore
View file
Open in desktop
File renamed without changes.
10 changes: 10 additions & 0 deletions packages/asset-buyer/CHANGELOG.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
[
{
"version": "1.0.0-rc.1",
"changes": [
{
"note": "Init"
}
]
}
]
1 change: 1 addition & 0 deletions packages/asset-buyer/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

16 changes: 8 additions & 8 deletions packages/forwarder-helper/README.md → packages/asset-buyer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
## @0xproject/forwarder-helper
## @0xproject/asset-buyer

Provides convenience objects to help work with the Forwarder Contract
Convenience package for buying assets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide a more elaborate description, this is too vague.


### Read the [Documentation](https://0xproject.com/docs/forwarder-helper).
### Read the [Documentation](https://0xproject.com/docs/asset-buyer).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there really be a documentation page for this package? If "eventually" is the answer, let's remove this line for now.


## Installation

```bash
yarn add @0xproject/forwarder-helper
yarn add @0xproject/asset-buyer
```

**Import**

```typescript
import { forwarderHelperFactory } from '@0xproject/forwarder-helper';
import { AssetBuyer } from '@0xproject/asset-buyer';
```

or

```javascript
var forwarderHelperFactory = require('@0xproject/forwarder-helper').forwarderHelperFactory;
var AssetBuyer = require('@0xproject/asset-buyer').AssetBuyer;
```

If your project is in [TypeScript](https://www.typescriptlang.org/), add the following to your `tsconfig.json`:
Expand Down Expand Up @@ -55,13 +55,13 @@ yarn install
To build this package and all other monorepo packages that it depends on, run the following from the monorepo root directory:

```bash
PKG=@0xproject/forwarder-helper yarn build
PKG=@0xproject/asset-buyer yarn build
```

Or continuously rebuild on change:

```bash
PKG=@0xproject/forwarder-helper yarn watch
PKG=@0xproject/asset-buyer yarn watch
```

### Clean
Expand Down
15 changes: 10 additions & 5 deletions packages/forwarder-helper/package.json → packages/asset-buyer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "@0xproject/forwarder-helper",
"version": "1.0.2",
"name": "@0xproject/asset-buyer",
"version": "1.0.0-rc.1",
"engines": {
"node": ">=6.12"
},
"description": "Convenience object for working with the forwarder contract",
"description": "Convenience package for buying assets",
"main": "lib/src/index.js",
"types": "lib/src/index.d.ts",
"scripts": {
Expand Down Expand Up @@ -34,21 +34,26 @@
"bugs": {
"url": "https://github.com/0xProject/0x-monorepo/issues"
},
"homepage": "https://github.com/0xProject/0x-monorepo/packages/forwarder-helper/README.md",
"homepage": "https://github.com/0xProject/0x-monorepo/packages/asset-buyer/README.md",
"dependencies": {
"@0xproject/assert": "^1.0.8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There has been a publish in the mean-time. This should be ^1.0.9 and others are probably also out-of-date.

"@0xproject/connect": "^2.0.0",
"@0xproject/contract-wrappers": "^1.0.1",
"@0xproject/json-schemas": "^1.0.1",
"@0xproject/order-utils": "^1.0.1",
"@0xproject/subproviders": "^2.0.2",
"@0xproject/types": "^1.0.1",
"@0xproject/typescript-typings": "^2.0.0",
"@0xproject/utils": "^1.0.8",
"@types/node": "^8.0.53",
"@0xproject/web3-wrapper": "^2.0.2",
"ethereum-types": "^1.0.6",
"lodash": "^4.17.10"
},
"devDependencies": {
"@0xproject/tslint-config": "^1.0.7",
"@types/lodash": "^4.14.116",
"@types/mocha": "^2.2.42",
"@types/node": "^8.0.53",
"chai": "^4.0.1",
"chai-as-promised": "^7.1.0",
"chai-bignumber": "^2.0.1",
Expand Down
Loading