Cache order maker signature (ZEIP-15)

0xProject · Feb 14, 2018 · f1710f4 · f1710f4
1 parent 7e691ff
commit f1710f4
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/packages/contracts/src/contracts/current/protocol/Exchange/MixinExchangeCore.sol b/packages/contracts/src/contracts/current/protocol/Exchange/MixinExchangeCore.sol
@@ -97,14 +97,16 @@ contract MixinExchangeCore is
             orderHash: getOrderHash(orderAddresses, orderValues)
         });
 
-        // Validate maker
-        require(order.makerTokenAmount > 0);
-        require(order.takerTokenAmount > 0);
-        require(isValidSignature(
-            order.orderHash,
-            order.maker,
-            signature
-        ));
+        // Validate order and maker only if first time seen
+        if (filled[order.orderHash] == 0 && cancelled[order.orderHash] == 0) {
+            require(order.makerTokenAmount > 0);
+            require(order.takerTokenAmount > 0);
+            require(isValidSignature(
+                order.orderHash,
+                order.maker,
+                signature
+            ));
+        }
 
         // Validate taker
         if (order.taker != address(0)) {