Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Commit

Permalink
Added note about restriction on testDirectory
Browse files Browse the repository at this point in the history
  • Loading branch information
fabioberger committed Oct 16, 2018
1 parent e624587 commit 72f5719
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packages/monorepo-scripts/src/test_installation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ async function testInstallPackageAsync(
const packageName = installablePackage.packageJson.name;
utils.log(`Testing ${packageName}@${lastChangelogVersion}`);
const packageDirName = path.join(...(packageName + '-test').split('/'));
// NOTE(fabio): The `testDirectory` needs to be somewhere **outside** the monorepo root directory.
// Otherwise, it will have access to the hoisted `node_modules` directory and the Typescript missing
// type errors will not be caught.
const testDirectory = path.join(monorepoRootPath, '..', '.installation-test', packageDirName);
await rimrafAsync(testDirectory);
await mkdirpAsync(testDirectory);
Expand Down

0 comments on commit 72f5719

Please sign in to comment.