Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Commit

Permalink
CI test for dependencies to have the same version (#1556)
Browse files Browse the repository at this point in the history
* add failing CI for dependencies with multiple versions

* update dependencies

* increase bundlewatch maxsize for 0x.js
  • Loading branch information
xianny authored Feb 5, 2019
1 parent b2f3505 commit 703aa38
Show file tree
Hide file tree
Showing 39 changed files with 195 additions and 387 deletions.
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ jobs:
- repo-{{ .Environment.CIRCLE_SHA1 }}
- run: yarn lerna run lint
- run: yarn prettier:ci
- run: yarn deps_versions:ci
- run: cd packages/0x.js && yarn build:umd:prod
- run: yarn bundlewatch
submit-coverage:
Expand Down
7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"contracts/*"
],
"scripts": {
"deps_versions:ci": "node ./packages/monorepo-scripts/lib/deps_versions.js",
"ganache": "ganache-cli -p 8545 --gasLimit 10000000 --networkId 50 -m \"${npm_package_config_mnemonic}\"",
"prettier": "prettier --write '**/*.{ts,tsx,json,md}' --config .prettierrc",
"prettier:ci": "prettier --list-different '**/*.{ts,tsx,json,md}' --config .prettierrc",
Expand Down Expand Up @@ -44,13 +45,15 @@
"config": {
"contractsPackages": "@0x/contracts-asset-proxy @0x/contracts-erc20 @0x/contracts-erc721 @0x/contracts-exchange @0x/contracts-exchange-forwarder @0x/contracts-exchange-libs @0x/contracts-extensions @0x/contracts-multisig @0x/contracts-test-utils @0x/contracts-utils",
"mnemonic": "concert load couple harbor equip island argue ramp clarify fence smart topic",
"packagesWithDocPages": "0x.js connect json-schemas subproviders web3-wrapper contract-wrappers order-utils order-watcher sol-compiler sol-coverage sol-profiler sol-trace ethereum-types asset-buyer migrations"
"packagesWithDocPages": "0x.js connect json-schemas subproviders web3-wrapper contract-wrappers order-utils order-watcher sol-compiler sol-coverage sol-profiler sol-trace ethereum-types asset-buyer migrations",
"ignoreDependencyVersions": "@types/styled-components",
"ignoreDependencyVersionsForPackage": "website instant dev-tools-pages"
},
"bundlewatch": {
"files": [
{
"path": "packages/0x.js/_bundles/index.min.js",
"maxSize": "700kB"
"maxSize": "800kB"
},
{
"path": "packages/instant/umd/instant.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/0x.js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
"@types/web3-provider-engine": "^14.0.0",
"ethereum-types": "^1.1.6",
"ethers": "~4.0.4",
"lodash": "^4.17.5",
"lodash": "^4.17.11",
"web3-provider-engine": "14.0.6"
},
"publishConfig": {
Expand Down
2 changes: 1 addition & 1 deletion packages/abi-gen-wrappers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@0x/web3-wrapper": "^3.2.4",
"ethereum-types": "^1.1.6",
"ethers": "~4.0.4",
"lodash": "^4.17.5",
"lodash": "^4.17.11",
"shx": "^0.2.2"
},
"dependencies": {
Expand Down
10 changes: 5 additions & 5 deletions packages/abi-gen/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"ethereum-types": "^1.1.6",
"glob": "^7.1.2",
"handlebars": "^4.0.11",
"lodash": "^4.17.5",
"lodash": "^4.17.11",
"mkdirp": "^0.5.1",
"sleep": "^5.1.1",
"tmp": "^0.0.33",
Expand All @@ -48,15 +48,15 @@
"@0x/tslint-config": "^2.0.2",
"@types/glob": "5.0.35",
"@types/handlebars": "^4.0.36",
"@types/mkdirp": "^0.5.1",
"@types/mkdirp": "^0.5.2",
"@types/node": "*",
"@types/sleep": "^0.0.7",
"@types/tmp": "^0.0.33",
"@types/yargs": "^10.0.0",
"chai": "^4.1.2",
"@types/yargs": "^11.0.0",
"chai": "^4.0.1",
"dirty-chai": "^2.0.1",
"make-promises-safe": "^1.1.0",
"mocha": "^5.2.0",
"mocha": "^4.1.0",
"npm-run-all": "^4.1.2",
"shx": "^0.2.2",
"tslint": "5.11.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/assert/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"@0x/json-schemas": "^2.1.7",
"@0x/typescript-typings": "^3.0.8",
"@0x/utils": "^3.0.1",
"lodash": "^4.17.5",
"lodash": "^4.17.11",
"valid-url": "^1.0.9"
},
"publishConfig": {
Expand Down
4 changes: 2 additions & 2 deletions packages/asset-buyer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@
"@0x/utils": "^3.0.1",
"@0x/web3-wrapper": "^3.2.4",
"ethereum-types": "^1.1.6",
"lodash": "^4.17.5"
"lodash": "^4.17.11"
},
"devDependencies": {
"@0x/tslint-config": "^2.0.2",
"@types/lodash": "^4.14.116",
"@types/lodash": "4.14.104",
"@types/mocha": "^2.2.42",
"@types/node": "*",
"chai": "^4.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/base-contract/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"@0x/web3-wrapper": "^3.2.4",
"ethereum-types": "^1.1.6",
"ethers": "~4.0.4",
"lodash": "^4.17.5"
"lodash": "^4.17.11"
},
"publishConfig": {
"access": "public"
Expand Down
6 changes: 3 additions & 3 deletions packages/connect/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
"@0x/types": "^1.5.2",
"@0x/typescript-typings": "^3.0.8",
"@0x/utils": "^3.0.1",
"lodash": "^4.17.5",
"query-string": "^5.0.1",
"lodash": "^4.17.11",
"query-string": "^6.0.0",
"sinon": "^4.0.0",
"uuid": "^3.3.2",
"websocket": "^1.0.25"
Expand All @@ -61,7 +61,7 @@
"@types/fetch-mock": "^6.0.3",
"@types/lodash": "4.14.104",
"@types/mocha": "^2.2.42",
"@types/query-string": "^5.0.1",
"@types/query-string": "^5.1.0",
"@types/sinon": "^2.2.2",
"@types/uuid": "^3.4.3",
"@types/websocket": "^0.0.39",
Expand Down
2 changes: 1 addition & 1 deletion packages/contract-addresses/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"typescript": "3.0.1"
},
"dependencies": {
"lodash": "^4.17.5"
"lodash": "^4.17.11"
},
"publishConfig": {
"access": "public"
Expand Down
6 changes: 3 additions & 3 deletions packages/contract-wrappers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"@types/mocha": "^2.2.42",
"@types/node": "*",
"@types/sinon": "^2.2.2",
"@types/uuid": "^3.4.2",
"@types/uuid": "^3.4.3",
"@types/web3-provider-engine": "^14.0.0",
"chai": "^4.0.1",
"chai-as-promised": "^7.1.0",
Expand Down Expand Up @@ -83,8 +83,8 @@
"ethereumjs-util": "^5.1.1",
"ethers": "~4.0.4",
"js-sha3": "^0.7.0",
"lodash": "^4.17.5",
"uuid": "^3.1.0"
"lodash": "^4.17.11",
"uuid": "^3.3.2"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-tools-pages/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"@types/node": "*",
"@types/react": "^16.4.2",
"@types/react-dom": "^16.0.7",
"@types/react-loadable": "^5.4.1",
"@types/react-loadable": "^5.4.2",
"@types/react-lottie": "^1.2.0",
"@types/react-router-dom": "^4.0.4",
"@types/react-tabs": "^2.3.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"@types/web3-provider-engine": "^14.0.0",
"chai": "^4.0.1",
"ethereum-types": "^1.1.6",
"lodash": "^4.17.5"
"lodash": "^4.17.11"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/fill-scenarios/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@0x/web3-wrapper": "^3.2.4",
"ethereum-types": "^1.1.6",
"ethers": "~4.0.4",
"lodash": "^4.17.5"
"lodash": "^4.17.11"
},
"publishConfig": {
"access": "public"
Expand Down
14 changes: 7 additions & 7 deletions packages/instant/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@
"bowser": "^1.9.4",
"copy-to-clipboard": "^3.0.8",
"ethereum-types": "^1.1.6",
"lodash": "^4.17.5",
"polished": "^2.2.0",
"lodash": "^4.17.11",
"polished": "^1.9.2",
"react": "^16.5.2",
"react-dom": "^16.5.2",
"react-redux": "^5.0.7",
"redux": "^4.0.0",
"redux-devtools-extension": "^2.13.5",
"rollbar": "^2.5.0",
"styled-components": "^4.0.2",
"styled-components": "^4.1.1",
"ts-optchain": "^0.1.1"
},
"devDependencies": {
Expand All @@ -72,10 +72,10 @@
"@types/enzyme": "^3.1.14",
"@types/enzyme-adapter-react-16": "^1.0.3",
"@types/jest": "^23.3.5",
"@types/lodash": "^4.14.116",
"@types/lodash": "4.14.104",
"@types/node": "*",
"@types/react": "^16.4.16",
"@types/react-dom": "^16.0.8",
"@types/react": "16.4.16",
"@types/react-dom": "16.0.6",
"@types/react-redux": "^6.0.9",
"@types/redux": "^3.6.0",
"@types/styled-components": "4.0.1",
Expand Down Expand Up @@ -103,7 +103,7 @@
"typedoc": "0.13.0",
"typescript": "3.0.1",
"webpack": "^4.20.2",
"webpack-cli": "^3.1.1",
"webpack-cli": "3.1.2",
"webpack-dev-server": "^3.1.9"
},
"publishConfig": {
Expand Down
4 changes: 2 additions & 2 deletions packages/metacoin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@
"@0x/typescript-typings": "^3.0.8",
"@0x/utils": "^3.0.1",
"@0x/web3-wrapper": "^3.2.4",
"@types/mocha": "^5.2.2",
"@types/mocha": "^2.2.42",
"copyfiles": "^2.0.0",
"ethereum-types": "^1.1.6",
"ethers": "~4.0.4",
"lodash": "^4.17.5",
"lodash": "^4.17.11",
"run-s": "^0.0.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/migrations/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@0x/dev-utils": "^1.0.24",
"@0x/tslint-config": "^2.0.2",
"@0x/types": "^1.5.2",
"@types/yargs": "^10.0.0",
"@types/yargs": "^11.0.0",
"make-promises-safe": "^1.1.0",
"npm-run-all": "^4.1.2",
"shx": "^0.2.2",
Expand All @@ -61,7 +61,7 @@
"@ledgerhq/hw-app-eth": "^4.3.0",
"ethereum-types": "^1.1.6",
"ethers": "~4.0.4",
"lodash": "^4.17.5"
"lodash": "^4.17.11"
},
"optionalDependencies": {
"@ledgerhq/hw-transport-node-hid": "^4.3.0"
Expand Down
6 changes: 3 additions & 3 deletions packages/monorepo-scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@
},
"homepage": "https://github.com/0xProject/0x-monorepo/packages/monorepo-scripts/README.md",
"devDependencies": {
"@types/glob": "^5.0.33",
"@types/glob": "5.0.35",
"@types/mkdirp": "^0.5.2",
"@types/node": "*",
"@types/opn": "^5.1.0",
"@types/rimraf": "^2.0.2",
"@types/semver": "5.5.0",
"@types/yargs": "^10.0.0",
"@types/yargs": "^11.0.0",
"depcheck": "^0.6.9",
"make-promises-safe": "^1.1.0",
"npm-run-all": "^4.1.2",
Expand All @@ -55,7 +55,7 @@
"es6-promisify": "^5.0.0",
"glob": "^7.1.2",
"isomorphic-fetch": "2.2.1",
"lodash": "^4.17.5",
"lodash": "^4.17.11",
"mkdirp": "^0.5.1",
"moment": "2.21.0",
"opn": "^5.3.0",
Expand Down
Loading

0 comments on commit 703aa38

Please sign in to comment.