address more comments

0xProject · Nov 26, 2019 · 4157665 · 4157665
1 parent 7483085
commit 4157665
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/contracts/exchange-forwarder/CHANGELOG.json b/contracts/exchange-forwarder/CHANGELOG.json
@@ -6,8 +6,7 @@
                 "note": "Added buy support for ERC20Bridge",
                 "pr": 2356
             }
-        ],
-        "timestamp": 1574461784
+        ]
     },
     {
         "version": "3.1.0-beta.3",

diff --git a/contracts/exchange-forwarder/test/asset_test.ts b/contracts/exchange-forwarder/test/asset_test.ts
@@ -160,7 +160,7 @@ blockchainTests('Supported asset type unit tests', env => {
                 .transferAssetToSender(erc721AssetData, invalidAmount)
                 .awaitTransactionSuccessAsync({ from: receiver });
             const expectedError = new ForwarderRevertErrors.Erc721AmountMustEqualOneError(invalidAmount);
-            expect(tx).to.revertWith(expectedError);
+            return expect(tx).to.revertWith(expectedError);
         });
         it('transfers an ERC20 token given ERC20Bridge assetData', async () => {
             const txReceipt = await forwarder
@@ -178,7 +178,7 @@ blockchainTests('Supported asset type unit tests', env => {
                 .transferAssetToSender(randomBytes, TRANSFER_AMOUNT)
                 .awaitTransactionSuccessAsync({ from: receiver });
             const expectedError = new ForwarderRevertErrors.UnsupportedAssetProxyError(hexSlice(randomBytes, 0, 4));
-            expect(tx).to.revertWith(expectedError);
+            return expect(tx).to.revertWith(expectedError);
         });
     });
 });
diff --git a/contracts/integrations/CHANGELOG.json b/contracts/integrations/CHANGELOG.json
@@ -3,11 +3,10 @@
         "version": "1.0.3-beta.2",
         "changes": [
             {
-                "note": "Forwader <> ERC20Bridge integration testsg",
+                "note": "Forwader <> ERC20Bridge integration tests",
                 "pr": 2356
             }
-        ],
-        "timestamp": 1574461784
+        ]
     },
     {
         "version": "1.0.3-beta.1",

diff --git a/contracts/integrations/test/forwarder/bridge_test.ts b/contracts/integrations/test/forwarder/bridge_test.ts
@@ -26,7 +26,7 @@ import { TestEth2DaiContract, TestUniswapExchangeContract } from '../wrappers';
 import { deployForwarderAsync } from './deploy_forwarder';
 import { ForwarderTestFactory } from './forwarder_test_factory';
 
-blockchainTests.resets.only('Forwarder <> ERC20Bridge integration tests', env => {
+blockchainTests.resets('Forwarder <> ERC20Bridge integration tests', env => {
     let deployment: DeploymentManager;
     let balanceStore: BlockchainBalanceStore;
     let testFactory: ForwarderTestFactory;