[asset-swapper] prune before dummy order creation

0xProject · Feb 5, 2020 · 3020266 · 3020266
1 parent f9c9b9f
commit 3020266
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 8 deletions.
diff --git a/packages/asset-swapper/CHANGELOG.json b/packages/asset-swapper/CHANGELOG.json
@@ -1,4 +1,12 @@
 [
+    {
+        "version": "4.1.1",
+        "changes": [
+            {
+                "note": "Prune orders before creating a dummy order for the Sampler"
+            }
+        ]
+    },
     {
         "version": "4.1.0",
         "changes": [

diff --git a/packages/asset-swapper/package.json b/packages/asset-swapper/package.json
@@ -9,6 +9,7 @@
     "types": "lib/src/index.d.ts",
     "scripts": {
         "build": "yarn tsc -b",
+        "watch": "tsc -w -p tsconfig.json",
         "build:ci": "yarn build",
         "lint": "tslint --format stylish --project .",
         "fix": "tslint --fix --format stylish --project .",

diff --git a/packages/asset-swapper/src/swap_quoter.ts b/packages/asset-swapper/src/swap_quoter.ts
@@ -250,7 +250,12 @@ export class SwapQuoter {
         const apiOrders = await this.orderbook.getBatchOrdersAsync(makerAssetDatas, [takerAssetData]);
         const allOrders = apiOrders.map(orders => orders.map(o => o.order));
         const allPrunedOrders = allOrders.map((orders, i) => {
-            if (orders.length === 0) {
+            const prunedOrders = orderPrunerUtils.pruneForUsableSignedOrders(
+                orders,
+                this.permittedOrderFeeTypes,
+                this.expiryBufferMs,
+            );
+            if (prunedOrders.length === 0) {
                 return [
                     dummyOrderUtils.createDummyOrderForSampler(
                         makerAssetDatas[i],
@@ -259,13 +264,7 @@ export class SwapQuoter {
                     ),
                 ];
             } else {
-                return sortingUtils.sortOrders(
-                    orderPrunerUtils.pruneForUsableSignedOrders(
-                        orders,
-                        this.permittedOrderFeeTypes,
-                        this.expiryBufferMs,
-                    ),
-                );
+                return sortingUtils.sortOrders(prunedOrders);
             }
         });