This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekz
force-pushed
the
feature/prices-endpoint
branch
3 times, most recently
from
January 14, 2020 00:40
aa57227
to
ec38ac0
Compare
dekz
force-pushed
the
feature/prices-endpoint
branch
2 times, most recently
from
January 23, 2020 02:50
415118a
to
a7c03e8
Compare
dekz
force-pushed
the
feature/prices-endpoint
branch
2 times, most recently
from
January 28, 2020 03:27
3d89ef4
to
a7b1509
Compare
fragosti
reviewed
Jan 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can we not return a price if we don't know it (ie. not return price: 0).
- My instinct was to query
/prices
. Thoughts on calling it that?
dekz
force-pushed
the
feature/prices-endpoint
branch
from
February 5, 2020 04:45
a7b1509
to
ac7a628
Compare
SGTM, updated to |
fragosti
approved these changes
Feb 5, 2020
dekz
force-pushed
the
feature/prices-endpoint
branch
from
February 12, 2020 06:37
ac7a628
to
2c6a92f
Compare
deploy staging |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently fetching prices of 1 unit of each token on with a base asset pair (defaults to WETH). I.e buying 1 USDC with WETH. We could make the
unitAmount
configurable by param.In essence this is similar to performing a quote on every asset with the base asset. So in essence we use Native and Bridge orders. We do this in batches, as at writing this results in concurrent ~4 RPC requests. Currently this takes approximately
3.5-50.8 seconds to serve the result.Note:
Perf
Staging
MY (slow) machine