fix: lower db pool connections (#319)

* fix: lower db pool connections * disable RFQT debug logging * exit early when all sources excluded * throw a validation error
0xProject · Aug 14, 2020 · bc9f218 · bc9f218
1 parent d9cb04d
commit bc9f218
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 4 deletions.
diff --git a/src/ormconfig.ts b/src/ormconfig.ts
@@ -14,6 +14,6 @@ export const config: ConnectionOptions = {
     logging: true,
     logger: 'debug',
     extra: {
-        max: 20,
+        max: 15,
     },
 };
diff --git a/src/services/swap_service.ts b/src/services/swap_service.ts
@@ -36,7 +36,7 @@ import {
     WRAP_QUOTE_GAS,
     ZERO,
 } from '../constants';
-import { InsufficientFundsError } from '../errors';
+import { InsufficientFundsError, ValidationError, ValidationErrorCodes } from '../errors';
 import { logger } from '../logger';
 import { TokenMetadatasForChains } from '../token_metadatas_for_networks';
 import {
@@ -74,8 +74,12 @@ export class SwapService {
             ...SWAP_QUOTER_OPTS,
             rfqt: {
                 ...SWAP_QUOTER_OPTS.rfqt,
-                warningLogger: logger.warn.bind(logger),
-                infoLogger: logger.info.bind(logger),
+                // tslint:disable-next-line:no-empty
+                warningLogger: () => {},
+                // tslint:disable-next-line:no-empty
+                infoLogger: () => {},
+                // warningLogger: logger.warn.bind(logger),
+                // infoLogger: logger.info.bind(logger),
             },
         };
         this._swapQuoter = new SwapQuoter(this._provider, orderbook, swapQuoterOpts);
@@ -449,6 +453,16 @@ export class SwapService {
             affiliateFee,
         } = params;
         let _rfqt: RfqtRequestOpts | undefined;
+        const isAllExcluded = Object.values(ERC20BridgeSource).every(s => excludedSources.includes(s));
+        if (isAllExcluded) {
+            throw new ValidationError([
+                {
+                    field: 'excludedSources',
+                    code: ValidationErrorCodes.ValueOutOfRange,
+                    reason: 'Request excluded all sources',
+                },
+            ]);
+        }
         if (apiKey !== undefined && (isETHSell || from !== undefined)) {
             let takerAddress;
             switch (swapVersion) {

diff --git a/src/token_metadatas_for_networks.ts b/src/token_metadatas_for_networks.ts
@@ -777,4 +777,14 @@ export const TokenMetadatasForChains: TokenMetadataAndChainAddresses[] = [
             [ChainId.Ganache]: NULL_ADDRESS,
         },
     },
+    {
+        symbol: 'CRV',
+        name: 'Curve DAO Token',
+        decimals: 18,
+        tokenAddresses: {
+            [ChainId.Mainnet]: '0xd533a949740bb3306d119cc777fa900ba034cd52',
+            [ChainId.Kovan]: NULL_ADDRESS,
+            [ChainId.Ganache]: NULL_ADDRESS,
+        },
+    },
 ];