feat: add a few usability functions to the interface #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: mpt_trie
BGluth
approved these changes
Apr 18, 2024
| #[test] | ||
| fn nibbles_as_byte_slice_works() -> Result<(), StrToNibblesError> { | ||
| let cases = [ | ||
| (0x0, vec![]), |
There was a problem hiding this comment.
Yeah I think this is good. Just reviewed what to_nibbles does for unsigned integers, and the 0x0 case also goes to an empty Nibbles and not the zero key.
Just an aside, but do you think this is good default behavior? Is this what you would expect, or should 0x0 map to the key 0x0 instead of empty?
There was a problem hiding this comment.
specifically in the context of nibbles empty makes more sense to me instead of 0x0, but it is debatable
BGluth
approved these changes
Apr 22, 2024
muursh
approved these changes
Apr 29, 2024
|
Can we update the changelog and we'll merge |
Nashtare
pushed a commit
that referenced
this pull request
May 20, 2024
* feat: add a few usability functions to the interface * fix: fix clippy issue * feat: add usize to nibbles * docs: update changelog.md --------- Co-authored-by: Vladimir Trifonov <[email protected]> Co-authored-by: Ben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add a few usability functions to the interface
Issue: #67