Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix gif #331

Merged
merged 1 commit into from
Nov 30, 2023
Merged

docs: fix gif #331

merged 1 commit into from
Nov 30, 2023

Conversation

Dominik1999
Copy link
Collaborator

@Dominik1999 Dominik1999 commented Nov 30, 2023

The cool new gif that captures the gist of Miden can not be rendered with the GitHubPages standard renderer.

The problem here is that Markdown on GitHub.com is rendered with our CommonMark-compatible renderer, but Pages by default uses kramdown. See here github/markup#1215

@Dominik1999 Dominik1999 force-pushed the dominik_add_correct_gif branch 2 times, most recently from 88d125b to 978c743 Compare November 30, 2023 16:00
@Dominik1999 Dominik1999 force-pushed the dominik_add_correct_gif branch from 978c743 to fed6a0d Compare November 30, 2023 16:05
Copy link
Contributor

@hackaugusto hackaugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dominik1999 Dominik1999 merged commit 6d0d417 into main Nov 30, 2023
6 checks passed
@Dominik1999 Dominik1999 deleted the dominik_add_correct_gif branch November 30, 2023 16:22
@bobbinth
Copy link
Contributor

I think this animation is cool - but it may be too complex for this specific place (but we can probably use it in other places). For this place, I actually thinking of this animation:

Screenshot 2023-11-30 at 10 32 55 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants