Add mined L1blocknumber to MonitoredTxResult #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnusmor
added
cherry-picked
agnusmor
requested review from
joanestebanr,
ToniRamirezM and
tclemos
as code owners
joanestebanr
approved these changes
Jul 18, 2024
agnusmor
added a commit
that referenced
this pull request
Aug 9, 2024
agnusmor
added a commit
that referenced
this pull request
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds mined L1blocknumber to MonitoredTxResult in eth-tx-manager. This info will be used by sequence-sender to perform the wait for L1Block confirmations
Reviewers
Main reviewers:
@joanestebanr
@ToniRamirezM
@tclemos