feijoa: l1infotree recursive #3474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recursive methods
joanestebanr
commented
Apr 2, 2024
| ProcessorBase: actions.ProcessorBase[ProcessorL1InfoTreeUpdate]{ | ||
| SupportedEvent: []etherman.EventOrder{etherman.L1InfoTreeOrder}, | ||
| SupportedForkdIds: &actions.ForksIdAll}, | ||
| ProcessorBase: *actions.NewProcessorBase[ProcessorL1InfoTreeUpdate]( |
There was a problem hiding this comment.
What is the reason for this change?
There was a problem hiding this comment.
Just a refactoring to match the way I understood the ProcessorBase struct was intended to be implemented.
There were some methods to expose the fields adding extra logic when accessing these fields, but the fields were public and, there was no constructor to the struct, it was mixed publicly and privately implemented, then I adjusted it to work in a private way.
This was done in the middle of other changes to the code, we can review it and change it if necessary.
…feijoa info tree processor forkid; refactoring l1InfoTreeV1 naming
tclemos
approved these changes
Apr 4, 2024
ARR552
reviewed
Apr 5, 2024
| testState := state.NewState(stateCfg, storage, nil, nil, nil, mt) | ||
| mtr, err := l1infotree.NewL1InfoTreeRecursive(32) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
Suggested change
| panic(err) | |
| require.NoError(t, err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3465
What does this PR do?
Reviewers
Main reviewers:
Codeowner reviewers: