Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick: 3451 synchronizer accept old forkids #3468

Merged

Conversation

joanestebanr
Copy link
Contributor

Closes #3451
Previous PR: #3452 (release 0.6.3)

What does this PR do?

Check incomming Forkid against Database:

  • if equal is skipped
  • If equal but differ in BlockNumber, the blockNumber is updated on database

Reviewers

Main reviewers:

Codeowner reviewers:

  • @-Alice
  • @-Bob

* #3451 accept same forkid from L1
* if same forkid recived and is the last one and same FromBatchNumber update blockNumber
@joanestebanr joanestebanr added synchronizer cherry-pick Content comes from a previous version branch zkevm-bridge-sync-rpc labels Mar 19, 2024
@joanestebanr joanestebanr added this to the v0.7.0 milestone Mar 19, 2024
@joanestebanr joanestebanr self-assigned this Mar 19, 2024
@cla-bot cla-bot bot added the cla-signed label Mar 19, 2024
@joanestebanr joanestebanr merged commit 3575157 into develop Mar 19, 2024
18 checks passed
@joanestebanr joanestebanr deleted the feature/cherry-pick-3451-sync-accept_old_forkids branch March 19, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick Content comes from a previous version branch cla-signed synchronizer zkevm-bridge-sync-rpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

synchronizer allows to reprocess forkids if are the same as stored on DB
2 participants