State interface

[ToniRamirezM]

First iteration of the State interface.

Everything is WIP so just review /state/state.go and /state/batchprocessor.go

[Mikelle]

why can't we just import it from polygon-sdk, if this is the same?

[tclemos]

Theoretically, we should use go-ethereum transaction until we identify we really need something else.

https://github.com/ethereum/go-ethereum/blob/master/core/types/transaction.go#L51

[ToniRamirezM]

Changed to user geth type

[tclemos]

From the JSONRpc perspective, we can start with these methods in the interface, and then we can figure out together the missing ones as I advance in the JSONRpc server development. For now LGTM 🎉

[tclemos]

It would be good to have a State interface instead of the implementation in order to allow other components to reference it and make it a testable code.

Theoretically, any service importing this library could write an interface to match the implementation, but this would require each service to implement its own interface, maybe having it centralized makes it easier for everyone. Also, this suggestion is not only for the State package but for all the packages that will be shared by the services.

Another relevant point IMO is that it makes it easier to identify all the exposed methods by the package without having to deal with the real code in the middle of the inspection.

With this approach, only the Interface needs to be public and the implementation can be private, making the interface with the package cleaner from the outside point of view.

[arnaubennassar]

When we are a bit more advanced in terms of code, I'd love to dedicate a session to talk about how can we handle testing. Maybe we can bring this topic then

[arnaubennassar]

Please fix the State struct content

[arnaubennassar]

When we are a bit more advanced in terms of code, I'd love to dedicate a session to talk about how can we handle testing. Maybe we can bring this topic then

[ARR552]

I'm missing a parameter to select the viratual state or the consolidated one

[ToniRamirezM]

Added the isVirtual bool

[ARR552]

I'm missing other functions:
func (s *State) GetLastBlock() (Block, error) //Block needs: BlockNum, Timestamp, Hash, ParentHash
func (s *State) GetLastBatch(isVirtual) (batch, error)
func (s *State) ResetState(batchNum) error

[ToniRamirezM]

Method added

[ARR552]

I'm missing a function:
func (s *State) ConsolidateBatch(batch) error to update the info when a consolidated batch is detected

[ToniRamirezM]

Method added