Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unit suffix from duration config params #1927

Closed
wants to merge 19 commits into from
Closed

remove unit suffix from duration config params #1927

wants to merge 19 commits into from

Conversation

tclemos
Copy link
Contributor

@tclemos tclemos commented Mar 24, 2023 •
edited by arnaubennassar
Loading

Closes #1926.
Closes #926.

What does this PR do?

  • Fix duration parameters
  • Remove pricegetter as it was unused
  • Add a .md to document config parameters

Reviewers

Main reviewers:

@arnaubennassar
@ToniRamirezM

@tclemos tclemos self-assigned this Mar 24, 2023
@cla-bot cla-bot bot added the cla-signed label Mar 24, 2023
@arnaubennassar arnaubennassar marked this pull request as draft March 24, 2023 18:47
@arnaubennassar arnaubennassar marked this pull request as ready for review April 4, 2023 15:36
@arnaubennassar arnaubennassar marked this pull request as draft April 11, 2023 08:51
@tclemos
Copy link
Contributor Author

tclemos commented May 2, 2023

closed due to #2068

@tclemos tclemos closed this May 2, 2023
@tclemos tclemos deleted the fix/duration-config branch May 2, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Psykepro Psykepro Psykepro approved these changes

@arnaubennassar arnaubennassar arnaubennassar approved these changes

@ToniRamirezM ToniRamirezM Awaiting requested review from ToniRamirezM ToniRamirezM is a code owner

@agnusmor agnusmor Awaiting requested review from agnusmor agnusmor will be requested when the pull request is marked ready for review agnusmor is a code owner

@joanestebanr joanestebanr Awaiting requested review from joanestebanr joanestebanr will be requested when the pull request is marked ready for review joanestebanr is a code owner

@ARR552 ARR552 Awaiting requested review from ARR552 ARR552 will be requested when the pull request is marked ready for review ARR552 is a code owner

Assignees

@tclemos tclemos

@arnaubennassar arnaubennassar

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better documentation of config file Fix duration config parameter names
3 participants
@tclemos @arnaubennassar @Psykepro