Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releases process must allow patch version >9 and generate testnet.zip file #2719

Closed
joanestebanr opened this issue Oct 26, 2023 · 0 comments · Fixed by #2713
Closed

Releases process must allow patch version >9 and generate testnet.zip file #2719

joanestebanr opened this issue Oct 26, 2023 · 0 comments · Fixed by #2713
Assignees
@joanestebanr
Labels
ci/cd zkevm-bridge-sync-rpc
Milestone
v0.3.2

Comments

@joanestebanr
Copy link
Contributor

System information

zkEVM Node version: v0.3.2
OS & Version: Windows/Linux/OSX
Commit hash :
Network: NA

Expected behaviour

  • The release process could generate a version that ends with more that 1 number e.g. x.y.10
  • It generate a testnet.zip file attached to the release

Actual behaviour

  • A release with a path version >10 is not generated
  • Fails the generation of testnet.zip
@joanestebanr joanestebanr self-assigned this Oct 26, 2023
@joanestebanr joanestebanr added this to the v0.3.2 milestone Oct 26, 2023
@joanestebanr joanestebanr mentioned this issue Oct 26, 2023
Merged
joanestebanr added a commit that referenced this issue Oct 26, 2023
@joanestebanr
#2607, #2719 Set the right version of releases binaries, allow releas…
7893a5a 
…es with patch version >9, generate testnet.zip
@joanestebanr joanestebanr mentioned this issue Oct 26, 2023
Merged
joanestebanr added a commit that referenced this issue Oct 26, 2023
@joanestebanr
#2607, #2719 Set the right version of releases binaries, allow releas…
d35b1d4 
…es with patch version >9, generate testnet.zip (#2720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joanestebanr joanestebanr

Labels
ci/cd zkevm-bridge-sync-rpc
Projects
None yet
Milestone
v0.3.2
Development

Successfully merging a pull request may close this issue.

add LDFLAGS to goreleaser to include in the binary the right, version 0xPolygonHermez/zkevm-node
1 participant
@joanestebanr