New executor error: Balance Mismatch (#1720)

* new executor error * fix test
0xPolygonHermez · Mar 7, 2023 · 296d97e · 296d97e
1 parent 420f1d0
commit 296d97e
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 16 deletions.
diff --git a/proto/src/proto/executor/v1/executor.proto b/proto/src/proto/executor/v1/executor.proto
@@ -276,4 +276,6 @@ enum ExecutorError {
     EXECUTOR_ERROR_COUNTERS_OVERFLOW_POSEIDON = 7;
     // EXECUTOR_ERROR_UNSUPPORTED_FORK_ID indicates that the fork id is not supported
     EXECUTOR_ERROR_UNSUPPORTED_FORK_ID = 8;
+    // EXECUTOR_ERROR_BALANCE_MISMATCH indicates that there is a balance mismatch error in the ROM
+    EXECUTOR_ERROR_BALANCE_MISMATCH = 9;
 }
diff --git a/state/runtime/executor/errors.go b/state/runtime/executor/errors.go
@@ -85,6 +85,8 @@ const (
 	EXECUTOR_ERROR_COUNTERS_OVERFLOW_POSEIDON = 7
 	// EXECUTOR_ERROR_UNSUPPORTED_FORK_ID indicates that the fork id is not supported
 	EXECUTOR_ERROR_UNSUPPORTED_FORK_ID = 8
+	// EXECUTOR_ERROR_BALANCE_MISMATCH indicates that there is a balance mismatch error in the ROM
+	EXECUTOR_ERROR_BALANCE_MISMATCH = 9
 )
 
 // RomErr returns an instance of error related to the ExecutorError
@@ -261,6 +263,8 @@ func ExecutorErr(errorCode pb.ExecutorError) error {
 		return runtime.ErrOutOfCountersPoseidon
 	case EXECUTOR_ERROR_UNSUPPORTED_FORK_ID:
 		return runtime.ErrUnsupportedForkId
+	case EXECUTOR_ERROR_BALANCE_MISMATCH:
+		return runtime.ErrBalanceMismatch
 	}
 	return fmt.Errorf("unknown error")
 }
@@ -284,6 +288,8 @@ func ExecutorErrorCode(err error) pb.ExecutorError {
 		return pb.ExecutorError(EXECUTOR_ERROR_COUNTERS_OVERFLOW_POSEIDON)
 	case runtime.ErrUnsupportedForkId:
 		return pb.ExecutorError(EXECUTOR_ERROR_UNSUPPORTED_FORK_ID)
+	case runtime.ErrBalanceMismatch:
+		return pb.ExecutorError(EXECUTOR_ERROR_BALANCE_MISMATCH)
 	}
 	return math.MaxInt32
 }
diff --git a/state/runtime/executor/pb/executor.pb.go b/state/runtime/executor/pb/executor.pb.go
diff --git a/state/runtime/runtime.go b/state/runtime/runtime.go
@@ -61,6 +61,8 @@ var (
 	ErrIntrinsicInvalidTxGasOverflow = errors.New("gas overflow")
 	// ErrUnsupportedForkId indicates that the fork id is not supported
 	ErrUnsupportedForkId = errors.New("unsupported fork id")
+	// ErrBalanceMismatch indicates that the balance mismatch in the ROM
+	ErrBalanceMismatch = errors.New("balance mismatch")
 )
 
 // ExecutionResult includes all output after executing given evm

diff --git a/state/state.go b/state/state.go
@@ -1690,7 +1690,7 @@ func (s *State) LogExecutorError(responseError pb.ExecutorError, processBatchReq
 		log.Errorf("error marshaling payload: %v", err)
 	} else {
 		debugInfo := &DebugInfo{
-			ErrorType: DebugInfoErrorType_EXECUTOR_ERROR,
+			ErrorType: DebugInfoErrorType_EXECUTOR_ERROR + " " + responseError.String(),
 			Timestamp: timestamp,
 			Payload:   string(payload),
 		}

diff --git a/state/state_test.go b/state/state_test.go
@@ -2746,7 +2746,7 @@ func TestStoreDebugInfo(t *testing.T) {
 
 	err = testState.PostgresStorage.QueryRow(ctx, "SELECT * FROM state.debug").Scan(&debugInfo.ErrorType, &debugInfo.Timestamp, &debugInfo.Payload)
 	assert.NoError(t, err)
-	assert.Equal(t, state.DebugInfoErrorType_EXECUTOR_ERROR, debugInfo.ErrorType)
+	assert.Equal(t, state.DebugInfoErrorType_EXECUTOR_ERROR+" "+executorclientpb.ExecutorError_EXECUTOR_ERROR_COUNTERS_OVERFLOW_KECCAK.String(), debugInfo.ErrorType)
 	assert.Equal(t, string(payload), debugInfo.Payload)
 }