Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Bump Go to 1.18 #776

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Bump Go to 1.18 #776

merged 2 commits into from
Oct 5, 2022

Conversation

vcastellm
Copy link
Contributor

@vcastellm vcastellm commented Oct 4, 2022

Description

Bumping Go version to 1.18

  • Extra bumping goreleaser/cross to official image.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Just run cluster multiple times

Documentation update

https://github.com/maticnetwork/matic-docs/pull/1117
https://wiki.polygon.technology/docs/edge/get-started/installation/#using-go-install

@vcastellm vcastellm added dependencies Update to the dependencies feature New update to Polygon Edge labels Oct 4, 2022
@vcastellm vcastellm self-assigned this Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #776 (13d64c1) into develop (ae056ef) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #776      +/-   ##
===========================================
+ Coverage    52.72%   52.85%   +0.13%     
===========================================
  Files          130      130              
  Lines        17147    17146       -1     
===========================================
+ Hits          9040     9062      +22     
+ Misses        7460     7439      -21     
+ Partials       647      645       -2     
Impacted Files Coverage Δ
jsonrpc/eth_endpoint.go 71.45% <100.00%> (-0.05%) ⬇️
jsonrpc/filter_manager.go 77.17% <100.00%> (+0.20%) ⬆️
network/server_discovery.go 89.80% <0.00%> (+14.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@epikichi
Copy link
Contributor

epikichi commented Oct 4, 2022

Can we possibly run a go mod tidy to get that taken care of as well?

@epikichi epikichi mentioned this pull request Oct 4, 2022
Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vcastellm vcastellm merged commit 690b4b4 into develop Oct 5, 2022
@vcastellm vcastellm deleted the feature/bump-go-118 branch October 5, 2022 09:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Update to the dependencies feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants