-
Notifications
You must be signed in to change notification settings - Fork 535
Add logging into e2e framework #771
Add logging into e2e framework #771
Conversation
…rate-e-2-e-consensus-tests-to-edge
…nto feature/EVM-51-add-logging-into-e-2-e-framework
Codecov Report
@@ Coverage Diff @@
## develop #771 +/- ##
===========================================
- Coverage 52.72% 52.71% -0.01%
===========================================
Files 130 130
Lines 17147 17147
===========================================
- Hits 9040 9039 -1
Misses 7460 7460
- Partials 647 648 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this improvement 💯
Not sure if I follow the format of the output logs. As was described in the task, each test has a name (i.e. QuorumNodesDropNodeAndSyncBack) and the format of the output directory looks like this:
Then, it is easy to organize the outputs by time (all the outputs in the same |
…nto feature/EVM-51-add-logging-into-e-2-e-framework
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
This will help a lot with troubleshooting process 👍
Totally right, I removed the detailed folder naming during the refactor and forgot to add it again, now it looks like: |
Also build with race to detect any.
…nto feature/EVM-51-add-logging-into-e-2-e-framework
…-logging-into-e-2-e-framework
Description
This PR enable optionally logging to different io.Writers, by default it saves the e2e logs output to a generated directory and upload the logs as an artifact for later inspection.
Changes include
Checklist
Testing
Manual tests
Run in local using
make test-e2e
Additional comments
This PR should be merged after #769