Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for jsonrpc.Log and jsonrpc.Receipt objects #1996

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Add unit tests for jsonrpc.Log and jsonrpc.Receipt objects #1996

merged 9 commits into from
Oct 26, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Oct 18, 2023 •
edited
Loading

Description

This PR implements additional unit tests for jsonrpc.Log and jsonrpc.Receipt structs.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal changed the title Add jsonrpc unit tests for log and receipt objects Add unit tests for jsonrpc.Log and jsonrpc.Receipt objects Oct 18, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Oct 23, 2023
@Stefan-Ethernal Stefan-Ethernal added feature New update to Polygon Edge bug fix Functionality that fixes a bug and removed feature New update to Polygon Edge labels Oct 23, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review October 23, 2023 13:48
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-204-add-jsonrpc-unit-tests-for-log-and-receipt-objects branch from 79b7a7f to a3b7185 Compare October 25, 2023 09:25
vcastellm
vcastellm approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stefan-Ethernal Stefan-Ethernal merged commit fbe5657 into develop Oct 26, 2023
6 of 7 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-204-add-jsonrpc-unit-tests-for-log-and-receipt-objects branch October 26, 2023 10:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@vcastellm vcastellm vcastellm approved these changes

@begmaroman begmaroman Awaiting requested review from begmaroman

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stefan-Ethernal @vcastellm @goran-ethernal