Implement unscubscribe on event stream #1991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements unsubscribe on event stream, that will be called when subscription is closed. Earlier event stream held slice of update channels which belonged to subscriptions and were used to notify subscription when the event is received (push fn). The problem here was if some subscription is closed, its update channel was not removed from the event stream, and since it is buffered channel of 5 events, after the buffer was full and events kept coming, push function was blocked on writing to that channel preventing other subscriptions to receive events. Earlier there was default branch, but we removed it to avoid loosing events.
With this fix events stream is changed to have map of subscription and when unsubscribe is called on event stream that will remove the subscription and close subscription channel.
Changes include
Checklist
Testing