Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM-850 Validator rootchain balance metrics #1941

Merged
merged 5 commits into from
Sep 29, 2023
Merged

EVM-850 Validator rootchain balance metrics #1941

merged 5 commits into from
Sep 29, 2023

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented Sep 27, 2023 •
edited by Stefan-Ethernal
Loading

Description

Egde should periodically retrieve validator balance from the root chain and output that information as a Prometheus metric.
A new server flag --metrics-interval has been introduced. By default, this flag returns 8s for interval. A value 0s will disable metrics.

Also checkpoint_block_number metric is moved from checkpoint_manager to the polybft and it is being published by each validator node.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the feature New update to Polygon Edge label Sep 27, 2023
@igorcrevar igorcrevar requested a review from a team September 27, 2023 10:20
@igorcrevar igorcrevar self-assigned this Sep 27, 2023
@igorcrevar igorcrevar force-pushed the feature/polybft_metrics branch 5 times, most recently from 4a800c8 to c45b186 Compare September 27, 2023 10:51
Stefan-Ethernal
Stefan-Ethernal reviewed Sep 27, 2023
View reviewed changes
consensus/polybft/state_stats.go Outdated Show resolved Hide resolved
consensus/polybft/state_stats.go Outdated Show resolved Hide resolved
@igorcrevar igorcrevar merged commit 6079322 into develop Sep 29, 2023
6 checks passed
@igorcrevar igorcrevar deleted the feature/polybft_metrics branch September 29, 2023 08:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
@vcastellm
Copy link
Contributor

Late LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@stana-miric stana-miric stana-miric approved these changes

@jelacamarko jelacamarko jelacamarko approved these changes

@begmaroman begmaroman begmaroman approved these changes

@Stefan-Ethernal Stefan-Ethernal Awaiting requested review from Stefan-Ethernal

Assignees

@igorcrevar igorcrevar

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@igorcrevar @vcastellm @begmaroman @jelacamarko @Stefan-Ethernal @stana-miric @goran-ethernal