Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a new transaction's price is not higher than the previously existing transaction, return ErrReplacementUnderpriced instead of ErrUnderpriced. I believe that this error was originally intended for this use. It can be useful when one has to tell whether the transaction with the requested nonce exists in the txpool after sendTransaction call.
Changes include
Breaking changes
Not sure, but it could be a breaking change in some sense.
The error message the client gets will change.
Checklist
Testing