Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ErrReplacementUnderpriced #1908

Merged

Conversation

ohijiho
Copy link
Contributor

@ohijiho ohijiho commented Sep 14, 2023

Description

When a new transaction's price is not higher than the previously existing transaction, return ErrReplacementUnderpriced instead of ErrUnderpriced. I believe that this error was originally intended for this use. It can be useful when one has to tell whether the transaction with the requested nonce exists in the txpool after sendTransaction call.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Not sure, but it could be a breaking change in some sense.

The error message the client gets will change.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx for your contribution!

@Stefan-Ethernal Stefan-Ethernal changed the title use ErrReplacementUnderpriced Use ErrReplacementUnderpriced Sep 18, 2023
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Sep 18, 2023
@Stefan-Ethernal Stefan-Ethernal merged commit 8aaae11 into 0xPolygon:develop Sep 26, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants