Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github] Max fee per gas issue #1892

Merged
merged 8 commits into from
Sep 8, 2023
Merged

[Github] Max fee per gas issue #1892

merged 8 commits into from
Sep 8, 2023

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Sep 8, 2023

Description

eth_call and eth_estimateGas endpoints are simulating transaction execution.
Transaction execution process has tx price so price-related fields should be provided in order to get transaction executed.
Currently, those two endpoints use a transaction object with an empty tx price so the simulation immediately fails.

This PR introduces a logic to apply gas price if a zero value is provided.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman self-assigned this Sep 8, 2023
@begmaroman begmaroman marked this pull request as ready for review September 8, 2023 09:06
@begmaroman begmaroman merged commit 400f388 into develop Sep 8, 2023
6 checks passed
@begmaroman begmaroman deleted the fix/EVM-832 branch September 8, 2023 09:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latest development branch - max fee per gas less than block base fee
5 participants