Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build executable heap with baseFee when London fork is enabled #1857

Merged
merged 23 commits into from
Sep 5, 2023
Merged

Build executable heap with baseFee when London fork is enabled #1857

merged 23 commits into from
Sep 5, 2023

Conversation

rachit77
Copy link
Contributor

Description

This PR intends to solve the issue explained here

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@rachit77 rachit77 added the bug fix Functionality that fixes a bug label Aug 29, 2023
@rachit77 rachit77 self-assigned this Aug 29, 2023
Stefan-Ethernal
Stefan-Ethernal reviewed Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you figure out some kind of tests?

Also, I believe the currently failing E2E tests are related to this change (at least the tx pool test and migration one: https://github.com/0xPolygon/polygon-edge/actions/runs/6009379628/job/16298691007?pr=1857).

@begmaroman
Copy link
Contributor

I suggest to make the PR title more usefull

@rachit77 rachit77 changed the title added logic Build executable heap with baseFee when London fork is enabled Aug 30, 2023
igorcrevar
igorcrevar reviewed Aug 31, 2023
View reviewed changes
txpool/account.go Outdated Show resolved Hide resolved
igorcrevar
igorcrevar approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@igorcrevar igorcrevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write some tests and check my other comment (changes for that are not mandatory).
otherwise lgtm

Stefan-Ethernal
Stefan-Ethernal approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, although I'd like to see some new tests implemented if possible.

txpool/txpool.go Outdated Show resolved Hide resolved
txpool/account.go Outdated Show resolved Hide resolved
vcastellm
vcastellm approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rachit77 rachit77 added breaking change Functionality that contains breaking changes don't merge Please don't merge this functionality temporarily labels Aug 31, 2023
@rachit77 rachit77 mentioned this pull request Sep 5, 2023
Closed
11 tasks
@rachit77 rachit77 merged commit 0635afe into 0xPolygon:develop Sep 5, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dusan-maksimovic dusan-maksimovic dusan-maksimovic approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@begmaroman begmaroman begmaroman approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@vcastellm vcastellm vcastellm approved these changes

Assignees

@rachit77 rachit77

Labels
breaking change Functionality that contains breaking changes bug fix Functionality that fixes a bug don't merge Please don't merge this functionality temporarily
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rachit77 @begmaroman @vcastellm @igorcrevar @Stefan-Ethernal @dusan-maksimovic