Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy proxy contracts on genesis #1855

Merged
merged 8 commits into from
Sep 11, 2023

Conversation

stana-miric
Copy link
Contributor

@stana-miric stana-miric commented Aug 28, 2023

Description

This PR introduces integration of edge code with proxy smart contracts.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Documentation

@DannyS03 parameter proxy-contracts-admin for genesis command is added in this PR. This is address of the account that will be set as an admin from proxy contract and this address will be able to update address implementation(logic) contract

command/genesis/polybft_params.go Outdated Show resolved Hide resolved
consensus/polybft/polybft.go Show resolved Hide resolved
command/genesis/polybft_params.go Outdated Show resolved Hide resolved
command/genesis/params.go Show resolved Hide resolved
consensus/polybft/polybft.go Outdated Show resolved Hide resolved
chain/params.go Outdated Show resolved Hide resolved
@stana-miric stana-miric marked this pull request as ready for review August 31, 2023 12:53
Base automatically changed from feat/slashing to develop September 6, 2023 06:16
@stana-miric stana-miric force-pushed the EVM-795-proxy-contract-integration branch from 5fc3f68 to 5e41153 Compare September 6, 2023 08:28
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-795-proxy-contract-integration branch from 5e41153 to 837f82e Compare September 6, 2023 14:42
@stana-miric stana-miric force-pushed the EVM-795-proxy-contract-integration branch from 828249e to d9c329b Compare September 8, 2023 10:14
@stana-miric stana-miric force-pushed the EVM-795-proxy-contract-integration branch from d9c329b to 13e7cca Compare September 8, 2023 10:34
@stana-miric stana-miric merged commit 6d848ed into develop Sep 11, 2023
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-795-proxy-contract-integration branch October 20, 2023 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants