-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation for newPendingTransactions (eth_subscribe) #1787
Merged
stana-miric
merged 3 commits into
develop
from
EVM-756-implement-new-pending-transaction
Aug 9, 2023
Merged
Implementation for newPendingTransactions (eth_subscribe) #1787
stana-miric
merged 3 commits into
develop
from
EVM-756-implement-new-pending-transaction
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusan-maksimovic
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, leaving some feedback to consider.
Stefan-Ethernal
approved these changes
Aug 9, 2023
vcastellm
reviewed
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces implementation of newPendingTransaction as a parameter of eth_subscribe. User can subscribe to this parameter and receive updates when the new tx is added to the tx pool.
Changes include
Checklist
Testing
Manual tests
Custer is run using e2e test which periodically inserts transactions
In a separate console we subscribed to newPendingTransaction events using following command:
wscat -c ws://localhost:12001/ws -x '{"jsonrpc":"2.0", "id": 1, "method":"eth_subscribe", "params": ["newPendingTransactions"]}' -w 120
Documentation update
@DannyS03 if we have documented which json rpc calls we support, then we should add newPendingTransaction as a part of eth_subscribe