Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-720 Implement json output for all commands #1724

Merged
merged 11 commits into from
Jul 24, 2023

Conversation

jelacamarko
Copy link
Contributor

@jelacamarko jelacamarko commented Jul 14, 2023

Description

This PR includes setting JSON output for the rootchain deploy command. The result of the deploy contracts is returned and set using outputter.SetCommandResult

WriteCommandResult in jsonOutput is fixed to print JSON object.

Setting the --json flag on the command doesn't affect OutputFormatter Write method, and every output created using that method will be in the original format.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@jelacamarko jelacamarko self-assigned this Jul 14, 2023
@jelacamarko jelacamarko requested review from Stefan-Ethernal and a team July 14, 2023 12:48
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some feedback to consider, otherwise looking good.

command/rootchain/deploy/deploy.go Outdated Show resolved Hide resolved
command/rootchain/deploy/deploy.go Outdated Show resolved Hide resolved
command/rootchain/deploy/deploy.go Show resolved Hide resolved
command/rootchain/deploy/deploy.go Outdated Show resolved Hide resolved
command/rootchain/deploy/deploy.go Outdated Show resolved Hide resolved
@Stefan-Ethernal Stefan-Ethernal requested a review from a team July 20, 2023 14:45
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Jul 20, 2023
@jelacamarko jelacamarko merged commit d554d2c into develop Jul 24, 2023
@jelacamarko jelacamarko deleted the evm-720-Implement-json-output-for-all-commands branch July 24, 2023 07:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants