-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM-720 Implement json output for all commands #1724
Merged
jelacamarko
merged 11 commits into
develop
from
evm-720-Implement-json-output-for-all-commands
Jul 24, 2023
Merged
EVM-720 Implement json output for all commands #1724
jelacamarko
merged 11 commits into
develop
from
evm-720-Implement-json-output-for-all-commands
Jul 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com:0xPolygon/polygon-edge into evm-720-Implement-json-output-for-all-commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some feedback to consider, otherwise looking good.
Stefan-Ethernal
approved these changes
Jul 20, 2023
dusan-maksimovic
approved these changes
Jul 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes setting JSON output for the rootchain deploy command. The result of the deploy contracts is returned and set using
outputter.SetCommandResult
WriteCommandResult
injsonOutput
is fixed to print JSON object.Setting the
--json
flag on the command doesn't affectOutputFormatter
Write
method, and every output created using that method will be in the original format.Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it