Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eth_estimateGas panic #1708

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Conversation

owahlgren
Copy link
Contributor

Description

eth_estimateGas panics with nil reference if arg param is nil ie
{ "jsonrpc":"2.0", "method":"eth_estimateGas", "params":[], "id":1 }
this change catches nil arg and throws appropriate error

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • [ x] I have tested this code with the official test suite
  • [ x] I have tested this code manually

Manual tests

curl -X POST --data '{"jsonrpc":"2.0","method":"eth_estimateGas","params":[],"id":1}' http://localhost:10002
now returns
"message": "missing value for required argument 0"

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@owahlgren
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@goran-ethernal goran-ethernal requested a review from a team July 10, 2023 06:58
@goran-ethernal goran-ethernal self-requested a review July 10, 2023 07:15
@goran-ethernal goran-ethernal self-requested a review July 10, 2023 07:16
@rachit77 rachit77 added the bug fix Functionality that fixes a bug label Jul 10, 2023
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to Goran's comment

@Nemanja0x Nemanja0x self-requested a review July 10, 2023 16:11
@goran-ethernal goran-ethernal merged commit 62148c1 into 0xPolygon:develop Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants