-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix eth_estimateGas panic #1708
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
rzmahmood
approved these changes
Jul 9, 2023
goran-ethernal
approved these changes
Jul 10, 2023
dusan-maksimovic
approved these changes
Jul 10, 2023
vcastellm
requested changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to Goran's comment
Nemanja0x
approved these changes
Jul 10, 2023
rachit77
approved these changes
Jul 10, 2023
vcastellm
approved these changes
Jul 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
eth_estimateGas panics with nil reference if arg param is nil ie
{ "jsonrpc":"2.0", "method":"eth_estimateGas", "params":[], "id":1 }
this change catches nil arg and throws appropriate error
Changes include
Checklist
Testing
Manual tests
curl -X POST --data '{"jsonrpc":"2.0","method":"eth_estimateGas","params":[],"id":1}' http://localhost:10002
now returns
"message": "missing value for required argument 0"