Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-543 Enable concurrent run of multiple dial tasks #1707

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented Jul 7, 2023

Description

Right now the dial task in runDial function are done sequentially because Connect is a blocking request. Change code to make up to connections concurrently. This will resolve related TODO comment in runDial function (network/server.go)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@igorcrevar igorcrevar added the feature New update to Polygon Edge label Jul 7, 2023
@igorcrevar igorcrevar self-assigned this Jul 7, 2023
@igorcrevar igorcrevar marked this pull request as ready for review July 7, 2023 16:22
@igorcrevar igorcrevar force-pushed the feature/EVM-543_concurrent-dial-tasks branch from f333d08 to 22dd383 Compare July 9, 2023 10:00
@igorcrevar igorcrevar force-pushed the feature/EVM-543_concurrent-dial-tasks branch from ad77ece to f98cd96 Compare July 10, 2023 08:54
@igorcrevar igorcrevar requested a review from rachit77 July 12, 2023 07:48
@igorcrevar igorcrevar merged commit f17b6ee into develop Jul 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants