Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TX pool debug level logging optimizations #1609

Merged

Conversation

dusan-maksimovic
Copy link
Contributor

Description

When there are a lot of txs being added to the tx pool, converting TX hash into string for logging takes a lot of time. If the log level isn't Debug or lower, this is unnecessary. Now we first check if the log level is Debug or lower before performing the conversion. Also added this check in couple places where sender address is logged on Debug level.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@dusan-maksimovic dusan-maksimovic added the bug fix Functionality that fixes a bug label Jun 12, 2023
@dusan-maksimovic dusan-maksimovic requested a review from a team June 12, 2023 11:32
@dusan-maksimovic dusan-maksimovic self-assigned this Jun 12, 2023
@dusan-maksimovic dusan-maksimovic merged commit 5b536ed into develop Jun 12, 2023
@dusan-maksimovic dusan-maksimovic deleted the EVM-690-transaction-hashes-logging-tx-pool branch June 12, 2023 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants