Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jesse/fix-nightly-v1.0.0-rc1 #1600

Merged
merged 5 commits into from
Jun 12, 2023
Merged

jesse/fix-nightly-v1.0.0-rc1 #1600

merged 5 commits into from
Jun 12, 2023

Conversation

gatsbyz
Copy link
Contributor

@gatsbyz gatsbyz commented Jun 8, 2023

No description provided.

@gatsbyz gatsbyz temporarily deployed to devnet June 8, 2023 22:07 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet June 9, 2023 14:33 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet June 9, 2023 17:31 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet June 9, 2023 18:57 — with GitHub Actions Inactive
Stefan-Ethernal
Stefan-Ethernal reviewed Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a bit more context, what was wrong with the previous version of the nightly workflow?

.github/workflows/deploy.nightly.devnet.yml Outdated Show resolved Hide resolved
@gatsbyz gatsbyz temporarily deployed to devnet June 12, 2023 14:46 — with GitHub Actions Inactive
@gatsbyz
Copy link
Contributor Author

gatsbyz commented Jun 12, 2023 •
edited
Loading

Can you provide a bit more context, what was wrong with the previous version of the nightly workflow?

@Stefan-Ethernal I updated the script to use the --test flag. The stake command was failing with the error staking transaction failed on block. And this is because a ERC20StakeToken needs to be deployed. We learned that the --test flag is doing this in the back, so we included it in this nightly script. Hope this explains.

@gatsbyz gatsbyz temporarily deployed to devnet June 12, 2023 15:06 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet June 12, 2023 15:11 — with GitHub Actions Inactive
@gatsbyz gatsbyz temporarily deployed to devnet June 12, 2023 15:15 — with GitHub Actions Inactive
@gatsbyz gatsbyz merged commit 827b08b into develop Jun 12, 2023
@gatsbyz gatsbyz deleted the jesse/fix-nightly-v1.0.0-rc1 branch June 12, 2023 17:11
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@praetoriansentry praetoriansentry praetoriansentry approved these changes

@vcastellm vcastellm vcastellm approved these changes

@Nemanja0x Nemanja0x Awaiting requested review from Nemanja0x

@Stefan-Ethernal Stefan-Ethernal Awaiting requested review from Stefan-Ethernal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gatsbyz @vcastellm @praetoriansentry @Stefan-Ethernal