Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-437 Batch calls over websockets not working properly #1588

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

igorcrevar
Copy link
Contributor

Description

There was no support for batch requests over web socket in edge

HI Team - [@Jesse Lee](https://0xpolygon.slack.com/team/U044LBPUHUG) and I observed that polycli monitor didn't work properly when connected to Edge via websocket.  It works fine on a standard HTTP transport. The root cause seems to be that websocket RPC doesn't seem to support standard JSON RPC requests that are [batched.In](http://batched.in/) the example screenshot, I'm doing 4 things:


OK .Making a batch call over websocket to Alchemy. This works fine


NOT OK. Making a batch call over websocket to v0.7.1-alpha3 Nexon. This does not work.


NOT OK. Making a batch call over websocket to v0.6.2 Necon. This does not work.


OK. Making a batch call over HTTP to v0.7.1-alpha3 Nexon. This works fineJust wanted to check and see if we're doing something wrong or if this is expected behavior?

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Jun 6, 2023
@igorcrevar igorcrevar self-assigned this Jun 6, 2023
@igorcrevar igorcrevar force-pushed the feature/EVM-437-Batch-calls-WS branch 2 times, most recently from 243c55f to 95eab42 Compare June 6, 2023 08:19
@igorcrevar igorcrevar force-pushed the feature/EVM-437-Batch-calls-WS branch from 95eab42 to ce86eb3 Compare June 6, 2023 08:29
@igorcrevar igorcrevar force-pushed the feature/EVM-437-Batch-calls-WS branch 7 times, most recently from 383e5d7 to 89930ad Compare June 6, 2023 12:51
@igorcrevar igorcrevar force-pushed the feature/EVM-437-Batch-calls-WS branch from 89930ad to 160c21b Compare June 6, 2023 14:34
jsonrpc/dispatcher.go Outdated Show resolved Hide resolved
jsonrpc/dispatcher.go Show resolved Hide resolved
jsonrpc/dispatcher.go Show resolved Hide resolved
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorcrevar igorcrevar merged commit c1d3a79 into develop Jun 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the feature/EVM-437-Batch-calls-WS branch June 25, 2023 08:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants