-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM-437 Batch calls over websockets not working properly #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorcrevar
requested review from
vcastellm,
Nemanja0x,
Stefan-Ethernal,
stana-miric and
goran-ethernal
June 6, 2023 08:02
igorcrevar
force-pushed
the
feature/EVM-437-Batch-calls-WS
branch
2 times, most recently
from
June 6, 2023 08:19
243c55f
to
95eab42
Compare
igorcrevar
force-pushed
the
feature/EVM-437-Batch-calls-WS
branch
from
June 6, 2023 08:29
95eab42
to
ce86eb3
Compare
igorcrevar
force-pushed
the
feature/EVM-437-Batch-calls-WS
branch
7 times, most recently
from
June 6, 2023 12:51
383e5d7
to
89930ad
Compare
igorcrevar
force-pushed
the
feature/EVM-437-Batch-calls-WS
branch
from
June 6, 2023 14:34
89930ad
to
160c21b
Compare
Nemanja0x
approved these changes
Jun 7, 2023
Stefan-Ethernal
approved these changes
Jun 7, 2023
goran-ethernal
approved these changes
Jun 7, 2023
vcastellm
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was no support for batch requests over web socket in edge
Changes include
Checklist
Testing