-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Child chain mintable predicates E2E tests #1560
Merged
Stefan-Ethernal
merged 29 commits into
develop
from
EVM-654-implement-mintable-predicates-e-2-e-tests
Jun 5, 2023
Merged
Child chain mintable predicates E2E tests #1560
Stefan-Ethernal
merged 29 commits into
develop
from
EVM-654-implement-mintable-predicates-e-2-e-tests
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
force-pushed
the
EVM-670-deploy-access-list-mintable-predicates
branch
from
May 29, 2023 08:21
0e3fda9
to
5e40f7f
Compare
Stefan-Ethernal
added
feature
New update to Polygon Edge
breaking change
Functionality that contains breaking changes
labels
May 29, 2023
Stefan-Ethernal
force-pushed
the
EVM-654-implement-mintable-predicates-e-2-e-tests
branch
from
May 29, 2023 08:58
e6cab8d
to
36680bc
Compare
Base automatically changed from
EVM-670-deploy-access-list-mintable-predicates
to
develop
May 29, 2023 09:23
Stefan-Ethernal
force-pushed
the
EVM-654-implement-mintable-predicates-e-2-e-tests
branch
6 times, most recently
from
June 2, 2023 12:33
95d03fc
to
258e034
Compare
Stefan-Ethernal
changed the title
Mintable predicates E2E tests
Child chain mintable predicates E2E tests
Jun 2, 2023
igorcrevar
reviewed
Jun 2, 2023
igorcrevar
reviewed
Jun 2, 2023
igorcrevar
reviewed
Jun 2, 2023
igorcrevar
reviewed
Jun 2, 2023
igorcrevar
reviewed
Jun 2, 2023
igorcrevar
reviewed
Jun 2, 2023
igorcrevar
reviewed
Jun 2, 2023
Stefan-Ethernal
force-pushed
the
EVM-654-implement-mintable-predicates-e-2-e-tests
branch
from
June 2, 2023 14:40
163374d
to
a843c6d
Compare
Stefan-Ethernal
force-pushed
the
EVM-654-implement-mintable-predicates-e-2-e-tests
branch
from
June 2, 2023 15:58
a843c6d
to
ee6a002
Compare
Nemanja0x
approved these changes
Jun 5, 2023
igorcrevar
approved these changes
Jun 5, 2023
* Consolidate bridge transaction result into single struct * Update SC to the latest spec * Fix * Add json tag to title field
Stefan-Ethernal
deleted the
EVM-654-implement-mintable-predicates-e-2-e-tests
branch
June 5, 2023 12:33
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tweaks CLI commands for sending bridge transactions and implements E2E tests which prove that child chain mintable predicates are working correctly.
Note that child chain mintable native token is mapped only on mintable predicates (it is prevented to be mapped in non-mintable ones).
Bridge CLI commands UX changes
Bridge deposit commands have a new flag called
--minter-key
, which represents the private key of the account that is able to do token minting (e.g. has associatedMINTER_ROLE
etc.). If it is provided, deposit command is going to mint tokens to the sender account (otherwise it would do just deposit).All bridge commands are enhanced with an additional flag called
--child-chain-mintable
. This flag denotes whether child chain mintable predicates are engaged in a given bridge transaction. It is used to determine whether exit events (akaL2StateSynced
events) are extracted from a receipt. Depending on the direction of assets bridging, exit events can be present either:Mandatory
stake-token
flag torootchain deploy
commandIntroduced mandatory stake-token flag to
rootchain deploy
command, because the previous approach was not correct, since instead of using root chain native token, we were using child chain native token root chain pairing address.E2E tests
Implemented two e2e tests, which are bridging child chain-originated tokens (mintable native tokens and ERC721 tokens).
Changes include
Checklist
Testing