TxnType is not returned in JSON-RPC response #1440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The transaction type is not returned in the json-rpc reponse leading to in correct client hash calculations.
Default TxType is 0 = LegacyTx.
Changes include
Breaking changes
The transaction response now includes a
type
field, which will tell the end user if the txn is aLegacyTx
,StateTx
, orDynamicFeeTx
. I believe this is required for EIP1559 txns to be processed and displayed correctly.Checklist
Testing