Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TxnType is not returned in JSON-RPC response #1440

Merged
merged 4 commits into from
May 2, 2023

Conversation

flavor-town
Copy link
Contributor

@flavor-town flavor-town commented Apr 26, 2023

Description

The transaction type is not returned in the json-rpc reponse leading to in correct client hash calculations.
Default TxType is 0 = LegacyTx.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

The transaction response now includes a type field, which will tell the end user if the txn is a LegacyTx, StateTx, or DynamicFeeTx. I believe this is required for EIP1559 txns to be processed and displayed correctly.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pay attention to this failing unit test: TestBlock_Encoding. Otherwise looks good.

@vcastellm vcastellm requested a review from a team April 27, 2023 08:49
@Stefan-Ethernal Stefan-Ethernal requested a review from a team May 1, 2023 18:18
@Stefan-Ethernal Stefan-Ethernal merged commit bb3dd32 into 0xPolygon:develop May 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants